Skip to content

[CR109] Custom Filters styling not applied for Filter lists and Add custom filter lists #27647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rebron opened this issue Jan 4, 2023 · 4 comments · Fixed by brave/brave-core#25315

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 4, 2023

Description

Styling is not applied for Filter lists and Add custom filter lists.
Follow-up to #27450

Steps to Reproduce

  1. Visit brave://settings/shields/filters in 1.47.61 with CR 109
  2. Notice styling is off for Custom lists, lacking borders and background fill see screenshot in Expected result.

Actual result:

Screenshot 2023-01-04 at 2 14 18 PM

Screenshot 2023-01-04 at 2 20 11 PM

Expected result:

Screenshot 2023-01-04 at 2 14 45 PM

Screenshot 2023-01-04 at 2 22 05 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.47 with CR 109

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added feature/settings regression priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jan 4, 2023
@zenparsing zenparsing self-assigned this Jan 26, 2024
@rebron rebron moved this to P3 backlog in Settings May 28, 2024
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 14, 2024
@ParagGhatage
Copy link

@rebron
I would love to work on this issue.
Will you assign it to me?

@jagadeshjai
Copy link

Hey @ParagGhatage!

Are you still interested in fixing this bug? If so, just mention it here, and you can get started right away!

@ParagGhatage
Copy link

Hey @ParagGhatage!

Are you still interested in fixing this bug? If so, just mention it here, and you can get started right away!

Thank you for reaching out. I’m currently focused on another issue, but I will begin working on this bug as soon as I’ve completed that task.

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.71.90 Chromium: 129.0.6668.59 (Official Build) beta (64-bit)
-- | --
Revision | 1f5f0d1b8a45a4c60a78c15df081751e39184b97
OS | Windows 11 Version 23H2 (Build 22631.4169)

Reproduced the issue in 1.70.117

image

  1. Installed 1.71.90
  2. launched Brave
  3. opened brave://settings/shields/filters
  • Confirmed styling is applied for Filter lists and Add custom filter lists
  • Confirmed the orange color highlight was removed

Light theme

image

Dark theme

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment