Command line option --no-default-browser-check seemingly ignored

[sam-ka]

I have used github issue search and normal web search to check similar open issues but I was not able to find issues similar to this one.

Description

Brave shows a small dialog window upon launch that prompts the user to set Brave as their default browser when a new profile is used for the first time.

This dialog should not be shown when brave's default browser check is disabled. However, the dialog is still shown when it is disabled via the command line option --no-default-browser-check, as documented by https://support.brave.com/hc/en-us/articles/360044860011-How-Do-I-Use-Command-Line-Flags-in-Brave-.

Steps to Reproduce

Run the browser with a fresh profile and the appropriate command line options. On linux via flatpak, run the following:

flatpak run com.brave.Browser --user-data-dir='/tmp/test.profile' --no-default-browser-check

Actual result:

The following prompt is shown when the browser is launched:

Expected result:

No prompt should be shown.

Reproduces how often:

This issue can be reproduced reliably every single time.

Brave version (brave://version info)

Brave	1.46.133 Chromium: 108.0.5359.71 (Official Build) unknown (64-bit)
Revision	1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS	Linux
JavaScript	V8 10.8.168.20
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36
Command Line	/app/brave/brave --disable-features=WebAssemblyTrapHandler,DesktopPWAsRunOnOsLogin --user-data-dir=/tmp/test.profile --no-default-browser-check --disable-domain-reliability --enable-dom-distiller --component-updater=url-source=https://go-updater.brave.com/extensions --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --disable-features=DesktopPWAsRunOnOsLogin,WebAssemblyTrapHandler --flag-switches-begin --flag-switches-end
Executable Path	/app/brave/brave
Profile Path	/tmp/test.profile/Default

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? I don't know
• Can you reproduce this issue with the nightly channel? I don't know

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

I just want to state that the ability to turn off special onboarding logic/blockers is necessary for real-world automated testing.