"On exit" tab's "clear data" option is grayed out (unelectable)

[Brave-Matt]

Description

Follow up to #26097
There are two problems when going to brave://settings/clearBrowserData --> On exit:

1. The option to save whatever data types are selected is grayed out and cannot be selected:
   
2. The option displays Save rather than Clear data as it did previously. I'm not clear on whether or not this was intentional (but I do think it makes more sense this way, since you're not actually clearing data on that click).

Steps to Reproduce

1. Visit brave://settings/clearBrowserData --> [On exit]
2. Select a data type to be cleared on exit
3. Observe Save button

Reproduces how often:

Always

Brave version (brave://version info)

v1.45.127

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

Internal discussion:
https://bravesoftware.slack.com/archives/C02DT9F5EP5/p1666647065097729
Community report:
https://community.brave.com/t/brave-not-deleting-history-and-no-option-to-save-on-exit-settings/441397/7

[MadhaviSeelam]

Verification PASSED using

Brave | 1.48.122 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Reproduced the issue in 1.46.153 where Save button is grayed out when options are selected

• Browsing history, Download history, Cookies and other site data, Passwords and other sign-in data, Autofill form data, Site and Shields Settings

1. Install 1.48.122
2. launch Brave
3. Skip onboarding
4. open brave://settings/clearBrowserData
5. click On exit
6. select all of the options except for Hosted app data:
   • Browsing history, Download history, Cookies and other site data, Cached images and files, Passwords and other sign-in data, Autofill form data, Site and Shields Settings
7. confirmed Save button is enabled
8. click Save
9. close all the tabs (to confirm Browsing history is cleared)
10. close and relaunch Brave
11. open brave://settings/clearBrowserData

Confirmed Save button is enabled after selecting options

Confirmed browsing history is deleted

step 5	step 7	result

[stephendonner]

Verified PASSED using

Brave	1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	macOS Version 11.7.2 (Build 20G1020)

Steps:

1. installed 1.48.129
2. launched Brave
3. skipped onboarding
4. opened brave://settings/clearBrowserData
5. clicked On exit
6. selected all of the options except for Hosted app data:
   • Browsing history, Download history, Cookies and other site data, Cached images and files, Passwords and other sign-in data, Autofill form data, Site and Shields Settings
7. confirmed Save button is enabled
8. clicked Save
9. closed all the tabs (to confirm Browsing history is cleared)
10. closed and relaunch Brave
11. opened brave://settings/clearBrowserData

Confirmed Save button is enabled after selecting options

Confirmed browsing history is deleted

step 5	step 7	result

[MadhaviSeelam]

Verification PASSED using

Brave | 1.48.140 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Linux

Pre-requisite: Have data for following:

• Browsing history, Download history, Cookies and other site data, Passwords and other sign-in data, Autofill form data, Site and Shields Settings

1. Install 1.48.140
2. launch Brave
3. open a new-tab
4. open brave://settings/clearBrowserData
5. click On exit
6. select all of the options except for Hosted app data:
   • Browsing history, Download history, Cookies and other site data, Cached images and files, Passwords and other sign-in data, Autofill form data, Site and Shields Settings
7. confirmed Save button is enabled
8. click Save
9. close all the tabs (to confirm Browsing history is cleared)
10. close and relaunch Brave
11. open brave://settings/clearBrowserData

Confirmed Save button is enabled after selecting options

Confirmed browsing history is deleted

step 5	step 7	result