Skip to content

set kDesktopSharingHubEnabled to true but hide/remove Share link to section #26019

Closed
brave/brave-core
#15479
@rebron

Description

@rebron

Description

Add Desktop sharing hub but hide or remove share link section

Actual result:

In current release, 1.44.112 and lower -

Shows only QR code icon
Screenshot 2022-10-13 at 7 19 01 PM

Visit any website and click on url bar and notice QR code icon. Selection of QR code icon will show a QR code for the website.

Expected result:

  1. Screen 1 - Default menu

Screenshot 2022-10-24 at 12 48 54 PM

  1. Screen 2 - Menu with sync enabled Send to your Devices

Screenshot 2022-10-24 at 12 59 36 PM

Screenshot 2022-10-24 at 12 59 42 PM

  1. Screen 3 - Menu with cast enabled

Screenshot 2022-10-24 at 1 03 56 PM

Screenshot 2022-10-24 at 1 06 09 PM

  1. Screen 4 - Menu with all enabled.

Screenshot 2022-10-24 at 1 06 49 PM

Test Plan

New Profile

  1. Use version 1.45.112 or higher.
  2. Create a new profile, go to any website and enter url bar. Notice share icon in Expected result screen 1.
  3. Ensure that you can a) copy link, b) copy clean link, c) create a QR code and d) save page as to your computer.

Profile with Sync enabled

  1. Use version 1.45.112 or higher
  2. Use a profile that has sync enabled. Go to any website and enter url bar. Notice share icon menu in Expected result screen 2 and ensure Send to your Devices is listed.
  3. Ensure that you can Share to devices by selecting Send to your Devices and choosing the device to share to.

Profile with Cast enabled

  1. Use version 1.45.112 or higher.
  2. Use a profile that has Cast enabled by going to brave://settings/extensions and enabling Media Router. Relaunch after turning on. Notice share icon menu in Expected result screen 3 and ensure Cast... is listed in the menu.
  3. Ensure that you can Cast the page to your casting device/tv.

Profile with Cast and Sync enabled.

  1. Ensure what's listed in screen 4 displays after steps from Profile with Sync enabled and Profile with Cast enabled.

Brave version (brave://version info)

Target release 1.45.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issues:
#20757
#25621

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions