Incorrect error dialog used when credentials fail

[stephendonner]

Description

Incorrect error dialog used when credentials fail

Steps to Reproduce

1. Complete the steps under Brave Premium login > Purchasing VPN with a new account from Implement Brave VPN on Desktop #15804, making sure to specify the current month and year for the credit card's expiration date
2. confirm you can connect to your new Brave VPN account
3. shut down Brave
4. open Date & Time in System Preferences and advance the OS date to the 1st of next month
5. relaunch Brave
6. connect to Brave VPN

Actual result:

Expected result:

From Figma:

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.41.5 Chromium: 102.0.5005.50 (Official Build) nightly (x86_64)
Revision	f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS	macOS Version 11.6.6 (Build 20G624)

@aguscruiz @bsclifton @simonhong @brave/qa-team

[spylogsster]

@stephendonner cannot reproduce, could you recheck pls?

[stephendonner]

@stephendonner cannot reproduce, could you recheck pls?

Can still reproduce using

Brave	1.42.13 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	macOS Version 12.5 (Build 21G5046c)

[stephendonner]

Verified PASSED using

Brave	1.46.68 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	macOS Version 13.0 (Build 22A379)

Followed my original steps to reproduce from #22972 (comment).

Confirmed the correct payment-error dialog is triggered in this specific case, with the correct wording.

10/18/2022	11/1/2022	Edit payment method dialog

[GeetaSarvadnya]

@stephendonner @MadhaviSeelam I have followed the STR from the description. When I advance the system date to 1st of next month (1st Dec 2022) I am not getting Edit payment menthod popup when I tap on the VPN icon in the URL bar. VPN is still in the connected state.

23rd Nov	1st Dec	1st Dec

[stephendonner]

@stephendonner @MadhaviSeelam I have followed the STR from the description. When I advance the system date to 1st of next month (1st Dec 2022) I am not getting Edit payment menthod popup when I tap on the VPN icon in the URL bar. VPN is still in the connected state.

Same. Using

Brave	1.46.126 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
Revision	18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS	Windows 10 Version 22H2 (Build 19045.2311)

I follow the same steps, and after advancing to the 1st of next month (from today's correct issue date of 11-23-2022), and relaunching Brave, BraveVPN is still able to connect without throwing up the Edit your payment dialog we see on macOS.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.131 Chromium: 108.0.5359.71 (Official Build) (64-bit)
-- | --
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Windows 10 Version 21H2 (Build 19044.2251)

• Verified the STR from the description, On 1st of Dec we are getting "Connected" state which is correct as the subscription is purchased on Nov 30th and subcription is valid till 32 days.

• Encountered and logged Once the Brave VPN is enabled/created the tokens are expired before the 30 days #26982

Thread for the tokens expiry discussion https://bravesoftware.slack.com/archives/C021S0FN3V1/p1669314173558939?thread_ts=1669225513.288039&cid=C021S0FN3V1

Nov 30th

Example	Example

Dec 1st

Example	Example