Skip to content

Selecting Localhost sets both Ethereum and Solana Localhost #22959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue May 20, 2022 · 2 comments · Fixed by brave/brave-core#13411
Closed

Selecting Localhost sets both Ethereum and Solana Localhost #22959

srirambv opened this issue May 20, 2022 · 2 comments · Fixed by brave/brave-core#13411
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Selecting Localhost sets both Ethereum and Solana Localhost

Steps to Reproduce

  1. Create wallet
  2. Select Localhost under Ethereum from network dropdown
  3. Widget/Panel shows Solana Localhost as localhost of both networks are selected

Actual result:

Localhost.mov

Expected result:

Should only set the selected network localhost

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.39.109 Chromium: 102.0.5005.50 (Official Build) (64-bit)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @jamesmudgett

@srirambv srirambv added this to Web3 May 20, 2022
@Douglashdaniel Douglashdaniel self-assigned this May 20, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 20, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label May 20, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 May 20, 2022
Repository owner moved this from In Review to Done in Web3 May 20, 2022
@Douglashdaniel Douglashdaniel added this to the 1.41.x - Nightly milestone May 20, 2022
@Uni-verse
Copy link
Contributor

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 11 Version 21H2 (Build 22000.318)

Followed STR in #22959 (comment)

  • Confirmed localhost will be set for the selected network and shown properly in hover state.
  • Confirmed localhost correctly displayed in Buy and Send Tabs
Example Example
Screen Shot 2022-07-08 at 12 41 26 PM Screen Shot 2022-07-08 at 12 41 39 PM

@Uni-verse
Copy link
Contributor

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Linux (Debian version 11)

Followed STR in #22959 (comment)

  • Confirmed localhost will be set for the selected network and shown properly in hover state.
  • Confirmed localhost correctly displayed in Buy and Send Tabs
Example Example
Screen Shot 2022-07-08 at 2 04 33 PM Screen Shot 2022-07-08 at 2 05 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants