Skip to content

Token name is missing from approve spend limit screen on testnet #19556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#11351
Closed

Token name is missing from approve spend limit screen on testnet #19556

srirambv opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#11351
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Token name is missing from approve spend limit screen on testnet

Steps to Reproduce

  1. Connect wallet on https://app.uniswap.org
  2. Initiate a UNI->ETH swap transaction
  3. Token name is missing on the popup confirmation

Actual result:

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.34.22 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Found while testing uplift for brave/brave-core#11132
@srirambv srirambv added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 18, 2021
@srirambv srirambv mentioned this issue Nov 18, 2021
Merged
24 tasks
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 18, 2021
@srirambv srirambv mentioned this issue Nov 23, 2021
Closed
@Douglashdaniel Douglashdaniel self-assigned this Nov 30, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 30, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 1, 2021
@srirambv
Copy link
Contributor Author

Brave 1.35.93 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
19556-Linux.mp4
19556-Windows.mov
19556-macOS.mov

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Fallback to FullTokenList in TransactionParser brave/brave-core
3 participants
@bbondy @srirambv @Douglashdaniel