Skip to content

Remove Hardcoded URL in AllowSpend Panel #19534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Douglashdaniel opened this issue Nov 17, 2021 · 1 comment · Fixed by brave/brave-core#11132
Closed

Remove Hardcoded URL in AllowSpend Panel #19534

Douglashdaniel opened this issue Nov 17, 2021 · 1 comment · Fixed by brave/brave-core#11132
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.32.x - Release #2

Comments

@Douglashdaniel
Copy link

Description

The AllowSpend Panel has a hardcoded value of 'https://app.compound.finance' needs to be removed and passed the sites origin.
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 17, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 17, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 17, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 17, 2021
@kjozwiak kjozwiak mentioned this issue Nov 18, 2021
Merged
7 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Nov 19, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 11 Version 21H2 (Build 22000.318)

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release #2
Development

Successfully merging a pull request may close this issue.

Passed Active Origin to Allow Spend Panel brave/brave-core
3 participants
@kjozwiak @srirambv @Douglashdaniel