Skip to content

Update stub executable for brave/Squirrel.Windows  #1782

Closed
@bsclifton

Description

@bsclifton

This is a Windows specific task

When Squirrel updates are done for the browser-laptop product, replacement executables are downloaded (including the binary for the stub installer)

The proposed updates (below) will accomplish the following:

  • Folks that have default browser set as the Muon browser will now have Brave Core as the default
  • Existing shortcuts for the Muon product will launch into Brave Core (desktop, pinned to taskbar)
  • When automated install of brave-core is done, it can simply do an app.relaunch and the --import-from-muon (or similar) args should get propagated through to brave-core

This task involves the following steps:

  • Update our fork of Squirrel.Windows - the Squirrel stub executable needs to have the following logic:
    • check LOCAL install registry key at HKEY_CURRENT_USER\Software\BraveSoftware\Update\path
    • If key exists, modify path (to find application); replace Update\BraveUpdate.exe with Brave-Browser\Application\brave.exe
    • If this file exists, launch into this - DONE
    • If this key DOES NOT exist, check HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\path
    • If key exists, modify path (to find application); replace Update\BraveUpdate.exe with Brave-Browser\Application\brave.exe
    • If this file exists, launch into this - DONE
    • If no registry keys were found, fall back to default behavior (load highest version app-X folder from directory stub installer lives in (ex: %USERPROFILE%\AppData\Local\brave\) - DONE
  • Update the executables in Muon Winstaller to have the new StubExecutable.exe
  • Update Muon Winstaller dependency in browser-laptop
  • Update product name (if possible) to Brave (old) or Brave (Muon)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions