Skip to content

Blocking NTPSI ad through 30-day history does not work #17743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btlechowski opened this issue Aug 27, 2021 · 2 comments
Closed

Blocking NTPSI ad through 30-day history does not work #17743

btlechowski opened this issue Aug 27, 2021 · 2 comments
Assignees
@tmancey
Labels
blocked closed/duplicate Issue has already been reported feature/ads OS/Desktop

Comments

@btlechowski
Copy link

Users have another way of blocking NTPSI ads (new tab page customization), but we should determine what to do with blocking NTPSI through 30-day history

Steps to Reproduce

  1. Follow steps from Blocked NTP SI ad - Untargeted segment from https://github.com/brave/internal/issues/794

Actual result:

Blocking NTPSI ad through 30-day history does not work

Expected result:

TBD by design

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.29.67 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Linux

cc @tmancey @jsecretan @rebron @brave/legacy_qa
@btlechowski btlechowski added design A design change, especially one which needs input from the design team QA/Yes QA/Test-Plan-Specified feature/ads OS/Desktop labels Aug 27, 2021
@btlechowski btlechowski mentioned this issue Aug 27, 2021
Closed
@tmancey tmancey added blocked needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed QA/Yes QA/Test-Plan-Specified labels Sep 1, 2021
@tmancey tmancey removed design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Feb 15, 2022
@tmancey
Copy link
Contributor

tmancey commented Feb 15, 2022

Will be resolved by brave/brave-core#11945

@tmancey
Copy link
Contributor

tmancey commented Feb 15, 2022

Closing as a duplicate of brave/brave-core#11945 as if ads are enabled we will be serving NTP SI ads from the ads library

@tmancey tmancey closed this as completed Feb 15, 2022
@tmancey tmancey added the closed/duplicate Issue has already been reported label Feb 15, 2022
@tmancey tmancey self-assigned this Feb 15, 2022
@tmancey tmancey mentioned this issue Feb 15, 2022
Merged
25 tasks
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
blocked closed/duplicate Issue has already been reported feature/ads OS/Desktop
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @btlechowski