Skip to content

Fails to fire ad notification event due to missing uuid #17008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmancey opened this issue Jul 16, 2021 · 1 comment · Fixed by brave/brave-core#9476
Closed

Fails to fire ad notification event due to missing uuid #17008

tmancey opened this issue Jul 16, 2021 · 1 comment · Fixed by brave/brave-core#9476
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 16, 2021

Description

Steps to Reproduce

  1. View an ad notification

Actual result:

"Fails to fire ad notification event due to missing uuid" appears in the logs

Expected result:

"Fails to fire ad notification event due to missing uuid" should not appear in the logs

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified PASSED using the testplan from #17008 (comment) with build

Brave 1.27.106 Chromium: 92.0.4515.101 (Official Build) (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Confirmed visually and via logs:

[44851:259:0721/165721.867060:VERBOSE1:ad_notification_serving.cc(187)] Serving ad notification:
  uuid: 51deddbb-c1d6-4794-8504-8ddc62c180da
  creativeInstanceId: 10b8a8c1-4308-40f5-b6df-5281cf5ef628
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad1
  body: Ad1
  targetUrl: https://brave.com
[44851:259:0721/165721.867842:VERBOSE1:ads_service_impl.cc(1881)] Timeout ad notification with uuid 51deddbb-c1d6-4794-8504-8ddc62c180da in 120 seconds
[44851:259:0721/165721.867914:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid 51deddbb-c1d6-4794-8504-8ddc62c180da and creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628
[44851:259:0721/165721.867991:VERBOSE1:ad_notification_serving.cc(123)] Served ad notification
[44851:259:0721/165721.868058:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 51deddbb-c1d6-4794-8504-8ddc62c180da and creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628
[44851:259:0721/165721.868185:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628
[44851:259:0721/165721.868925:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[44851:259:0721/165721.868972:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[44851:259:0721/165721.869005:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[44851:259:0721/165721.869037:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/4....
  Content: {"blindedPaymentToken":"Pr3tu6M5+chlYVoleD/5lBWMJ6+4soJ/COTmNtsJRmo=","buildChannel":"release","countryCode":"US","creativeInstanceId":"10b8a8c1-4308-40f5-b6df-5281cf5ef628","payload":{},"platform":"macos","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[44851:259:0721/165721.889772:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[44851:259:0721/165721.891667:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[44851:259:0721/165722.407638:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[44851:259:0721/165722.407752:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/4....
  Response Status Code: 201
  Response: {"id":"48c84212-34fd-4af4-ad66-cf923c052035","payload":{},"createdAt":"2021-07-21T23:57:22.222Z","type":"view","modifiedAt":"2021-07-21T23:57:22.222Z","creativeInstanceId":"10b8a8c1-4308-40f5-b6df-5281cf5ef628"}
[44851:259:0721/165722.408010:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[44851:259:0721/165722.408082:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[44851:259:0721/165722.408138:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/48c84212-34fd-4af4-ad66-cf923c052035/paymentToken
  Method: GET
[44851:259:0721/165722.549101:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[44851:259:0721/165722.549189:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/48c84212-34fd-4af4-ad66-cf923c052035/paymentToken
  Response Status Code: 200
  Response: {"id":"4......
Successfully redeemed unblinded token with confirmation id 48c84212-34fd-4af4-ad66-cf923c052035, creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628 and view
[44851:259:0721/165722.550563:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens
[44851:259:0721/165722.552052:VERBOSE1:refill_unblinded_tokens.cc(66)] No need to refill unblinded tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
[44851:259:0721/165723.260392:VERBOSE1:ads_service_impl.cc(1026)] Cancelled timeout for ad notification with uuid 51deddbb-c1d6-4794-8504-8ddc62c180da
[44851:259:0721/165723.347646:VERBOSE3:ad_notification_event_clicked.cc(26)] Clicked ad notification with uuid 51deddbb-c1d6-4794-8504-8ddc62c180da and creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628
[44851:259:0721/165723.349023:VERBOSE1:confirmations.cc(90)] Confirming click ad for creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628
[44851:259:0721/165723.352408:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[44851:259:0721/165723.352474:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[44851:259:0721/165723.352517:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[44851:259:0721/165723.352582:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/f.....
  Content: {"blindedPaymentToken":"DrL0hILwFvNpN/U1pvhFKvYmWMDor0oBo6ng8eZIf2o=","buildChannel":"release","countryCode":"US","creativeInstanceId":"10b8a8c1-4308-40f5-b6df-5281cf5ef628","payload":{},"platform":"macos","studies":[],"type":"click"}
  Content Type: application/json
  Method: POST
[44851:259:0721/165723.365907:VERBOSE1:ad_notification_event_clicked.cc(38)] Successfully logged ad notification clicked event
[44851:259:0721/165723.510631:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[44851:259:0721/165723.511292:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/f......
  Response Status Code: 201
  Response: {"id":"fd218b8d-6132-47cc-9c9c-231cce15d24e","payload":{},"createdAt":"2021-07-21T23:57:23.465Z","type":"click","modifiedAt":"2021-07-21T23:57:23.465Z","creativeInstanceId":"10b8a8c1-4308-40f5-b6df-5281cf5ef628"}
[44851:259:0721/165723.511431:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[44851:259:0721/165723.511480:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[44851:259:0721/165723.511513:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fd218b8d-6132-47cc-9c9c-231cce15d24e/paymentToken
  Method: GET
[44851:259:0721/165723.570129:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[44851:259:0721/165723.572356:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/fd218b8d-6132-47cc-9c9c-231cce15d24e/paymentToken
  Response Status Code: 200
  Response: {"id":"f.....
Successfully redeemed unblinded token with confirmation id fd218b8d-6132-47cc-9c9c-231cce15d24e, creative instance id 10b8a8c1-4308-40f5-b6df-5281cf5ef628 and click
[44851:259:0721/165723.572511:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 2 unblinded payment tokens

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants