Skip to content

Remove setting to toggle privacy sandbox #15871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jumde opened this issue May 14, 2021 · 4 comments · Fixed by brave/brave-core#8545
Closed

Remove setting to toggle privacy sandbox #15871

jumde opened this issue May 14, 2021 · 4 comments · Fixed by brave/brave-core#8545
Assignees
@mkarolin
Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Milestone
1.27.x - Release

Comments

@jumde
Copy link
Contributor

jumde commented May 14, 2021

Description

Setting to enable privacy sandbox is available in chromium starting CR92: chromium/chromium@02829f4

This should not be available to Brave users.
@jumde jumde added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 14, 2021
@rebron rebron added priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/settings priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels May 14, 2021
@rebron
Copy link
Collaborator

rebron commented May 25, 2021

cc: @mkarolin

@mkarolin mkarolin mentioned this issue May 26, 2021
Merged
24 tasks
@bbondy bbondy added this to the 1.28.x - Nightly milestone Jun 30, 2021
@mkarolin mkarolin self-assigned this Jun 30, 2021
@mkarolin mkarolin mentioned this issue Jul 7, 2021
Merged
24 tasks
@stephendonner
Copy link

Verified PASSED using

Brave 1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/privacy

Confirmed there's no Privacy Sandbox UI, as there is in Chrome Beta.

example example
Screen Shot 2021-07-12 at 3 15 27 PM Screen Shot 2021-07-12 at 3 15 41 PM

Will re-verify once it's uplifted to 1.27.x

@LaurenWags
Copy link
Member

LaurenWags commented Jul 15, 2021 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | macOS Version 10.15.7 (Build 19H1217)
Example Example
Privacy Search Privacy Sandbox

Verification passed on

Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)
Example Example
image image

Verification passed on

Brave 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS Ubuntu 18.04 LTS
Example Example
image image

@srirambv
Copy link
Contributor

Removing Android label as this setting is not applicable to Android. Also discussed with @jumde

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 91 to Chromium 92 brave/brave-core
9 participants
@stephendonner @bbondy @jumde @rebron @srirambv @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin