Skip to content

Automate the install of brave-core (macOS) #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
bsclifton opened this issue Oct 11, 2018 · 1 comment
Closed
6 tasks done

Automate the install of brave-core (macOS) #1541

bsclifton opened this issue Oct 11, 2018 · 1 comment
Assignees
@bsclifton
Labels
closed/invalid OS/macOS setup/installer

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 11, 2018 •
edited
Loading

Blocked on #1539

The goal for this task is to write the code needed to execute the install of brave-core from within browser-laptop. This would likely be a JavaScript file that we package with the build which could make the shell execute calls needed to perform the install via node.js

Requirements

  • Installer should be packaged into the browser-laptop release
  • Script should run once browser is launched
  • Install should be silent; no UI shown
  • Install should not happen if already installed
  • If install is not possible to /Applications/, it should install to ~/Applications/
  • Permissions should match actual install
@bsclifton bsclifton mentioned this issue Oct 11, 2018
Closed
@bbondy bbondy added this to the 1.x Backlog milestone Oct 16, 2018
@rebron rebron modified the milestones: 1.x Backlog, Muon => Brave Core migration Oct 19, 2018
@bsclifton bsclifton mentioned this issue Oct 22, 2018
Closed
4 tasks
@bsclifton bsclifton self-assigned this Oct 25, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 26, 2018
@bsclifton
Finish macOS automated install
ed4bffc 
Fixes brave/brave-browser#1541
Fixes brave/brave-browser#1543
bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 26, 2018
@bsclifton
Finish macOS automated install
b6724be 
Fixes brave/brave-browser#1541
Fixes brave/brave-browser#1543
@bsclifton
Copy link
Member Author

Fixed with brave/browser-laptop@b6724be

@bbondy bbondy modified the milestones: Muon => Brave Core migration, 0.59.x - Nightly, 0.56.x - Release Hotfix 1 Oct 30, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Finish macOS automated install
7cb4f5d 
Fixes brave/brave-browser#1541
Fixes brave/brave-browser#1543
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Automate brave-core install for macOS
a0e9ee8 
Fixes brave/brave-browser#1541
Fixes brave/brave-browser#1543
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Automate brave-core install for macOS
3cbd41c 
Fixes brave/brave-browser#1541
Fixes brave/brave-browser#1543
@bsclifton bsclifton mentioned this issue Nov 29, 2018
Closed
17 tasks
@bsclifton bsclifton modified the milestones: 0.57.x - Beta, Dupe / Invalid / Not actionable Nov 29, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
closed/invalid OS/macOS setup/installer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @bsclifton @rebron @srirambv