Skip to content

Automate the install of brave-core (Windows) #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 tasks done
bsclifton opened this issue Oct 11, 2018 · 5 comments
Closed
7 tasks done

Automate the install of brave-core (Windows) #1540

bsclifton opened this issue Oct 11, 2018 · 5 comments
Assignees
@bsclifton
Labels
closed/invalid OS/Windows setup/installer

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 11, 2018 •
edited
Loading

Blocked on #1538

The goal for this task is to write the code needed to execute the install of brave-core from within browser-laptop. This would likely be a JavaScript file that we package with the build which could make the shell execute calls needed to perform the install via node.js

Requirements

  • Installer should be packaged into the browser-laptop release
  • Script should run once browser is launched
  • Needs to execute appropriate installer (32-bit / 64-bit)
  • Install should be silent; no UI shown (should NOT escalate permissions, show UAC)
  • If brave-core is already installed, nothing needs to happen
  • Shortcuts to Brave and handlers for default browser should open brave-core
  • User should still be able to manually launch the binary at %userprofile%\AppData\Local\brave\app-0.26.0\Brave.exe (or similar)
@bsclifton bsclifton added this to the Muon => Brave Core migration milestone Oct 11, 2018
@bsclifton bsclifton mentioned this issue Oct 11, 2018
Closed
@bsclifton bsclifton added blocked and removed blocked labels Oct 11, 2018
@bsclifton bsclifton self-assigned this Oct 17, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 17, 2018
@bsclifton
First step toward solving brave/brave-browser#1540
553cc51
@bsclifton
Copy link
Member Author

Started work in https://github.com/brave/browser-laptop/tree/muon-upgrade-windows

@bsclifton
Copy link
Member Author

Blocked on #1782

@bsclifton bsclifton added blocked and removed blocked labels Oct 22, 2018
@bsclifton
Copy link
Member Author

Should be able to close this out today 😄 Just need to get a proper silent installer and add checks for when app is already installed

@bsclifton
Copy link
Member Author

@mbacchi can give me a hand tomorrow with the silent installer (also captured with https://github.com/brave/devops/issues/349)

Next step for me is to add logic to the install to skip install/import when brave-core is already installed 😄 Checking that out now

bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 25, 2018
@bsclifton
Added silent installers for 32/64 bit; updated install script to chec…
5882a33 
…k arch

Added check for existing installs; install will be skipped if already installed

Fixes brave/brave-browser#1540
@bsclifton
Copy link
Member Author

Resolved with brave/browser-laptop@5882a33

bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 26, 2018
@bsclifton
First step toward solving brave/brave-browser#1540
4cf04e0
bsclifton added a commit to brave/browser-laptop that referenced this issue Oct 26, 2018
@bsclifton
Added silent installers for 32/64 bit; updated install script to chec…
cb0de63 
…k arch

Added check for existing installs; install will be skipped if already installed

Fixes brave/brave-browser#1540
@bbondy bbondy modified the milestones: Muon => Brave Core migration, 1.x Backlog, 0.56.x - Release Hotfix 1 Oct 30, 2018
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
First step toward solving brave/brave-browser#1540
ff0aa2d
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Part 4 of fix for brave/brave-browser#1782
5905e8c 
- Updates friendly name of app (as shown in Default app settings) to `Brave (old)`

Fixes brave/brave-browser#1540
- Updated install script to check arch
- Added check for existing installs; install will be skipped if already installed
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Automate brave-core install for Windows. Includes an updated Squirrel…
f0e6054 
… stub executable.

Fixes brave/brave-browser#1540
Fixes brave/brave-browser#1782
- Stub executable detects brave-core and will launch it (instead of browser-laptop)
- Friendly name of app (as shown in Add/Remove programs and Default app settings) to `Brave (old)`
- Dependencies updated
bsclifton added a commit to brave/browser-laptop that referenced this issue Nov 7, 2018
@bsclifton
Automate brave-core install for Windows. Includes an updated Squirrel…
31fe22f 
… stub executable.

Fixes brave/brave-browser#1540
Fixes brave/brave-browser#1782
- Stub executable detects brave-core and will launch it (instead of browser-laptop)
- Friendly name of app (as shown in Add/Remove programs and Default app settings) to `Brave (old)`
- Dependencies updated
@bbondy bbondy removed this from the 0.56.x - Release Hotfix 1 milestone Nov 14, 2018
@bbondy bbondy added this to the 0.57.x - Beta milestone Nov 14, 2018
@bsclifton bsclifton modified the milestones: 0.57.x - Beta, Dupe / Invalid / Not actionable Nov 29, 2018
@bsclifton bsclifton mentioned this issue Nov 29, 2018
Closed
17 tasks
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
closed/invalid OS/Windows setup/installer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @bsclifton @srirambv