Skip to content

make it more clear in new tab text that Brave with Tor != Tor Browser #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diracdeltas opened this issue Feb 26, 2021 · 6 comments · Fixed by brave/brave-core#8091
Closed
Assignees
Labels

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Feb 26, 2021

There seems to be a common misconception that Brave's windows with Tor connectivity are supposed to be equivalent to Tor Browser, when in reality the threat model is pretty different. We launched the feature as a way for users to circumvent censorship and hide their true IP from websites and non-determined network observers, not nation-state attackers.

We state clearly in https://support.brave.com/hc/en-us/articles/360018121491 (linked from the new tab page) that "If your personal safety depends on remaining anonymous, we highly recommend using Tor Browser instead of Brave Tor windows." However this information should not require an extra link click to find out, given that many people think that "browser window with a Tor proxy" is synonymous with "Tor browser".

Suggestion:

Heading: "Private Window with Tor Connectivity"
Text below heading: Brave never remembers what you do in a Private Window, but regular Private Windows do not hide your IP address. With Tor connectivity, your IP address is hidden from the sites you visit. However, if your personal safety depends on remaining anonymous, we recommend using Tor Browser instead.

Lower heading: "This Private Window is more private with Tor Connectivity" / "Make this Private Window more private with Tor Connectivity"
Text below heading: Using Private Windows only changes what Brave does on your device — it doesn't change anyone else's behavior. Tor hides your IP address from the sites you visit and makes it somewhat more difficult, but not impossible, for your ISP or employer to see what sites you are visiting. Open a Private Window with Tor from the menu, or with ⌥⌘N.

@diracdeltas diracdeltas added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 26, 2021
@diracdeltas
Copy link
Member Author

@karenkliu any suggestions to my text? i think we should do this pretty quick given that there's no easy fix for #14262 without waiting on chromium.

@BrendanEich
Copy link
Member

Suggest "somewhat" over "slightly", but it's all a matter of cost. I think "somewhat" is more neutral. Thanks.

@diracdeltas
Copy link
Member Author

thanks, text updated!

@karenkliu
Copy link

@BrendanEich @diracdeltas Here's what this text might look like with our current Private Window with Tor design:
image

I took the liberty of culling a tiny bit of the text to fit in the space. LMK what you think.

Also, eventually we do want to refresh the design for Private Window/Private Window with maybe more search bar prominence, less text, and greater perceived clarity of what the two types of window hide/doesn't hide. This is what that might look like with this text update:
image
^^^ This future design is still in concept phase and needs more feedback. Just putting it here to give you a heads up.

@diracdeltas
Copy link
Member Author

@karenkliu thanks, this looks good to me

@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H524)

Verified text from brave/brave-core#8091 (review) and brave/brave-core#8091 (comment).

Private Window

1.21.74 1.22.55
1 21 74 Private 1 22 x Private

Also confirmed the "Learn more" link at the top of the page and the "Learn more about Tor in Brave" buttons navigated to support.brave.com pages with additional information.

Tor Window

1.21.74 1.22.55
1 21 74 Tor 1 22 x Tor

Also confirmed the "Learn more" link at the top of the page and the "Learn more about Tor in Brave" buttons navigated to support.brave.com pages with additional information.

Guest Window

1.21.74 1.22.55
1 21 74 Guest 1 22 x Guest

Also confirmed the "Learn more" link at the top of the page and the "Learn more about Tor in Brave" buttons navigated to support.brave.com pages with additional information.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants