Skip to content

breakpad_linux: backtrace ids fail and no linux crash ids are written locally to the users upload.log file #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkuehlz opened this issue Feb 23, 2021 · 2 comments · Fixed by brave/brave-core#8049
Closed

breakpad_linux: backtrace ids fail and no linux crash ids are written locally to the users upload.log file #14326

kkuehlz opened this issue Feb 23, 2021 · 2 comments · Fixed by brave/brave-core#8049
Assignees
@kkuehlz
Labels
bug OS/Desktop OS/Linux QA Pass-Linux QA/Yes release-notes/include
Milestone
1.23.x - Release

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Feb 23, 2021

Description

Steps to Reproduce

  1. Open browser process from the CLI
  2. Navigate to the url brave://inducebrowsercrashforrealz
  3. Watch the logs

Actual result:

--2021-02-22 12:36:38--  https://cr.brave.com
Resolving http://cr.brave.com (http://cr.brave.com)... 151.101.42.137, 2a04:4e42:a::649
Connecting to http://cr.brave.com (http://cr.brave.com)|151.101.42.137|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 36
Saving to: '/dev/fd/4'
     0K             
  Failed to get crash dump id. 
 Report Id:  ae310000-ab7a-e3

The backtrace report id is truncated on stdout, and nothing is written to the file ~/.config/BraveSoftware/Brave-Browser-Development/Crash\ Reports/uploads.log

Expected result:

--2021-02-23 12:30:46--  https://cr.brave.com/
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving cr.brave.com (cr.brave.com)... 151.101.26.137, 2a04:4e42:a::649
Connecting to cr.brave.com (cr.brave.com)|151.101.26.137|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 36
Saving to: ‘/dev/fd/4’

/dev/fd/4                                       100%[====================================================================================================>]      36  --.-KB/s    in 0s      


2021-02-23 12:30:46 (416 KB/s) - ‘/dev/fd/4’ saved [36/36]

Crash dump id: 983b0000-ab7a-e305-0000-000000000000
[1]    112181 abort (core dumped)  ./src/out/Component/brave --enable-crash-reporter-for-testing

Crash dump id is not truncated. The file ~/.config/BraveSoftware/Brave-Browser-Development/Crash\ Reports/uploads.log has a new line with the ID 983b0000-ab7a-e305-0000-000000000000

Reproduces how often:

Always

Brave version (brave://version info)

All versions

Version/Channel Information:

Affects all channels
@kkuehlz kkuehlz self-assigned this Feb 23, 2021
kkuehlz pushed a commit to brave/brave-core that referenced this issue Feb 23, 2021
breakpad: Patch breakpad to accept backtrace ids
d2c5bec 
Resolves brave/brave-browser#14326

This patch fixes breakpad to write crash ids to the file
Crash\ Reports/uploads.log. The old behavior was to silently fail at
this step since the backtrace crash Ids don't match Google crash ids.

Fixes:
  * Increase the size of the string kCrashIdLength from 16 to 36 because
    backtrace crash ids are longer than chromium crash ids.
  * Allow a dash in the id since the backtrace crash id format is:
    xxxxxxxx-xxxx-xxxx-0000-000000000000, where "x" is a hexadecimal
    character.
@kkuehlz kkuehlz added this to the 1.22.x - Nightly milestone Feb 23, 2021
@kkuehlz kkuehlz mentioned this issue Feb 23, 2021
Merged
17 tasks
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 4, 2021
@btlechowski
Copy link

Changed the milestone as the issue is fixed on 1.23.x and not on 1.22.x. I checked the commit history to confirm.

@btlechowski
Copy link

btlechowski commented Mar 7, 2021 •
edited
Loading

Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified test plan from the description

--2021-03-07 11:08:30--  https://cr.brave.com/
Resolving cr.brave.com (cr.brave.com)... 199.232.18.137
Connecting to cr.brave.com (cr.brave.com)|199.232.18.137|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 36
Saving to: ‘/dev/fd/4’

     0K                        
  Crash dump id:   1f1e0000-bef0-f505-0000-000000000000 
                          100%  764K=0s

2021-03-07 11:08:32 (764 KB/s) - ‘/dev/fd/4’ saved [36/36]

--2021-03-07 11:08:32--  https://cr.brave.com/
Resolving cr.brave.com (cr.brave.com)... 199.232.18.137
Connecting to cr.brave.com (cr.brave.com)|199.232.18.137|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 36
Saving to: ‘/dev/fd/4’

     0K                                
  Crash dump id:  201e0000-bef0-f505-0000-000000000000 
                   100%  565K=0s

2021-03-07 11:08:34 (565 KB/s) - ‘/dev/fd/4’ saved [36/36]

image
image

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 7, 2021
@LaurenWags LaurenWags mentioned this issue Apr 13, 2021
Closed
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 1, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
41ac987 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 8, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
de106cd 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 10, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
2496ea7 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
mkarolin pushed a commit to brave/brave-core that referenced this issue Nov 11, 2023
@cdesouza-chromium @mkarolin
Fix breakpad patch for IsValidCrashReportId
23f71a6 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 16, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
fbb119a 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 17, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
239fde1 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 24, 2023
@cdesouza-chromium
Fix breakpad patch for IsValidCrashReportId
259ef03 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
mkarolin pushed a commit to brave/brave-core that referenced this issue Nov 27, 2023
@cdesouza-chromium @mkarolin
Fix breakpad patch for IsValidCrashReportId
459bf2b 
This patch was introduced in the past to accept a backtrace. Recently
though changes upstream changed exactly the patched lines in question to
use an algorithm-based approach to check for the format of the ID.

This change creates a local function in a shadow file to act as a proxy
to make sure we preserve the `-` check as well as a valid id character.

Original issue: brave/brave-browser#14326

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a

commit b999986ff24699b81ecd3f45254a4bdf0332698a
Author: Peter Kasting <[email protected]>
Date:   Wed Oct 25 03:54:27 2023 +0000

    Shorten code by using existing helper APIs, eliminating temps.

    No functional change.

    Bug: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
bug OS/Desktop OS/Linux QA Pass-Linux QA/Yes release-notes/include
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging a pull request may close this issue.

breakpad: Patch breakpad to accept backtrace ids brave/brave-core
2 participants
@kkuehlz @btlechowski