Skip to content

Forward errors from component updater to ipfs observers #14229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spylogsster opened this issue Feb 17, 2021 · 1 comment · Fixed by brave/brave-core#8006
Closed

Forward errors from component updater to ipfs observers #14229

spylogsster opened this issue Feb 17, 2021 · 1 comment · Fixed by brave/brave-core#8006

Comments

@spylogsster
Copy link

spylogsster commented Feb 17, 2021

Description

Continuing off of the work in: brave/brave-core#7918 (comment)

Steps to Reproduce

  1. Clean profile
  2. Navigate to ipfs:// url to see interstitial page
  3. Click by local node button
  4. Disconnect internet cable

Actual result:

it hangs with "Installing" and never gives an error state

Expected result:

Expected result that error will be forwarded to the page

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    no
  • Can you reproduce this issue with the beta channel?
    no
  • Can you reproduce this issue with the nightly channel?
    no

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified FIXED using beta and the inline testplan here, with

Brave 1.22.51 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)
  1. Clean profile
  2. Navigate to ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html URL to see interstitial page
  3. Click Use a local node button
  4. After the button text changes status to Installing..., disconnect internet cable / disable Wi-Fi

Screen Shot 2021-03-03 at 10 27 11 AM

  1. Wait until the # of attempts has counted down/been exceeded

Screen Shot 2021-03-03 at 10 13 33 AM

  1. Reconnect ethernet cable / Wi-Fi
  2. Click the Try again button

Also tried, and verified:

  1. Repeat steps 1-4
  2. While the retry countdown happens, reconnect ethernet cable / Wi-Fi
  3. Confirmed that installation finishes and ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html automatically loads

waiting-ipfs

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment