Split out P3A checkbox from first run dialog on macOS and Linux

[karenkliu]

Description

Currently, the first run dialog contains a checkbox that combines P3A and crash reporting consent:

After discussing with the security/privacy/data team about privacy concerns around crash reporting and the longterm vision of obtaining P3A consent, we have decided to separate it out from the crash reports checkbox.

Designs

Separate out P3A from the crash reports checkbox and make sure crash reports is unchecked. Uplift this change for the 1.21x/Mar 2nd release:

Assets

Figma: https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/Desktop-Onboarding?node-id=1340%3A999

[rebron]

@simonhong Text update when you get a chance. We'll want to get this uplifted to into 1.21.x

[LaurenWags]

Removing QA/Blocked label, https://github.com/brave/brave-browser/releases/tag/v1.21.68 is available

[stephendonner]

Verification PASSED on macOS 11.1 x64 using the following build:

Brave	1.21.68 Chromium: 89.0.4389.58 (Official Build) (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.1 (Build 20D74)

Test Case #1 (leaving crash report unchecked)

• launched 1.21.68 Chromium: 89.0.4389.58 and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was disabled
• crashed Brave via brave://crash and ensured that the crash report appeared under brave://crashes but wasn't submitted
• ensured that restarting Brave didn't submit the crash report via brave://crashes
• ensured that clicking on Send now under brave://crashes sends the crash report to BackTrace
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #2 (enabled crash reporting)

• launched 1.21.68 Chromium: 89.0.4389.58 and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• selected Help improve Brave by automatically sending crash reports and clicked on Start Brave
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was enabled via brave://settings/privacy
• crashed Brave via brave://crash and ensured that the crash report appeared under brave://crashes and was automatically submitted
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #3 (Onboarding)

• ensured that clicking on completely private product analytics opens the following:
  • https://brave.com/privacy-preserving-product-analytics-p3a/
• ensured that Settings opens brave://settings/privacy

---

Verification passed on

Brave	1.21.70 Chromium: 89.0.4389.69 (Official Build) (64-bit)
Revision	6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7978

Test Case #1 (leaving crash report unchecked)

• launched and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was disabled
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #2 (enabled crash reporting)

• launched and ensured that Help improve Brave by automatically sending crash reports was not being selected by default
• selected Help improve Brave by automatically sending crash reports and clicked on Start Brave
• ensured that Automatically send completely private product analytics to Brave was enabled via brave://settings/privacy
• ensured that Help improve Brave's features and performance was enabled via brave://settings/privacy
• ensured that P3A is working/being updated via brave://local-state

Example	Example	Example

Test Case #3 (Onboarding)

• ensured that clicking on completely private product analytics opens the following:
  • https://brave.com/privacy-preserving-product-analytics-p3a/
• ensured that Settings opens brave://settings/privacy