-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Brave Ads should retry payments balance endpoint after redeeming unblinded payment tokens if balance is not ready #13721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Verified using
Verified STR from #13721 (comment) Used Charles Proxy to rewrite the response code for Confirmed that payments balance endpoint was retried. Additional testing re: "Estimated pending rewards" was done under #13601 (comment). Log examples
Verification passed on
Verified that after successfully redeemed unblinded payment tokens, the payment balance is retried. LogVerified when balance fails to be fetched, retry is scheduled
Verified that after successfully redeemed unblinded payment tokens, the payment balance is retried
The payment balance is retried:
Verification passed on
Verified that after successfully redeemed unblinded payment tokens, the payment balance is retried. Log
|
Description
Brave Ads should retry payments balance endpoint after redeeming unblinded payment tokens if balance is not ready
Steps to Reproduce
Actual result:
"Estimated pending rewards" is incorrectly shown after redeeming unblinded payment tokens if the payments balance end point is not ready, i.e. returns the last known balance
Expected result:
Should retry payments balance endpoint until the new balance is ready so that we can display the correct value for "Estimated pending rewards"
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Recommend to use Charles Proxy to rewrite the
GET /v1/confirmation/payment/{payment_id}
payments balance endpointThe text was updated successfully, but these errors were encountered: