Skip to content

[Desktop] Add handler for 410 in promotion claim flow #11161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NejcZdovc opened this issue Aug 11, 2020 · 2 comments · Fixed by brave/brave-core#6396
Closed

[Desktop] Add handler for 410 in promotion claim flow #11161

NejcZdovc opened this issue Aug 11, 2020 · 2 comments · Fixed by brave/brave-core#6396
Assignees
@NejcZdovc
Labels
feature/rewards OS/Desktop QA/No release-notes/include
Milestone
1.13.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

If server returns 410 when claiming promotion we should mark promotion as failed and stop retrying.
@NejcZdovc NejcZdovc self-assigned this Aug 11, 2020
@NejcZdovc
Copy link
Contributor Author

@evq to which endpoints you will add 410?

We talked about this one https://grant.rewards.brave.com/v1/promotions/424aab2c-3b95-5e7e-9ec3-1ca9349f5887. Anything else?

@NejcZdovc
Copy link
Contributor Author

server side implemented here brave-intl/bat-go#473

NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 11, 2020
@NejcZdovc
Adds 410 hanlder for promotion claim
1043b76 
Resolves brave/brave-browser#11161
@NejcZdovc NejcZdovc mentioned this issue Aug 11, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 11, 2020
@brave-builds brave-builds mentioned this issue Aug 14, 2020
Merged
4 tasks
@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Desktop QA/No release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Adds 410 hanlder for promotion claim brave/brave-core
1 participant
@NejcZdovc