[Desktop] Unable to delete/remove created wallet in Crypto wallets

[Brave-Matt]

Description

Some users are unable to delete/remove a created wallet in crypto wallets. Once reaching the appropriate menu, the Save and Cancel options disappear and the user is returned to the main page, the wallet is not actually deleted.

Steps to Reproduce

1. Go brave://wallet/.
2. Click on your profile avatar
3. Click on Settings
4. Click on Contacts
5. Click on My Wallet Accounts
6. Select the wallet you want to view
7. Click Edit
8. Click Delete Account

Actual result:

User is returned to main page, deleted wallet remains.

Expected result:

Wallet/account should be removed.

Reproduces how often:

Easily (for the user)

Brave version (brave://version info)

Windows 10 64 Bit Home. Brave Version - [Version 1.11.101 Chromium: 84.0.4147.89 (Official Build) (64-bit)]:

Version/Channel Information:

• Can you reproduce this issue with the current release? Y
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Original user report:
https://community.brave.com/t/i-cant-delete-my-2nd-wallet/146316

@ryanml mentions a likely fix in upcoming version update, when we rebase to MetaMask v8:
https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1596040670372800

[srirambv]

Verification passed on

Brave	1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
Revision	c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS	Windows 10 OS Version 1809 (Build 17763.1397)
Component	0.1.68

• Verified no Delete account option is shown in contacts
  

---

Verification passed on

Brave	1.13.75 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	Linux
Component	0.1.68

• Verified no Delete account option is shown in contacts
  

---

Verification passed on

Brave	1.14.55 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.15.5 (Build 19F101)
Component	0.1.68

• Verified no Delete account option is shown in contacts
  

[SnowmanUT]

Any fix for this as I have this problem and want to remove old metamask wallet that is hacked. Won't let me delete and is stuck hooked to uniswap so I have to use Chrome.

[srirambv]

Fixed via brave/ethereum-remote-client@b6a9d98

[Heten-Daiya]

@srirambv This issue #10999 has reappeared for me in Brave Version 1.19.92 Chromium: 88.0.4324.152 (Official Build) (64-bit) on Windows 10 Home Version 20H2 Build 19042.804

On clicking the edit button, there's no delete button there.

[urbenlegend]

This is happening to me too. This issue needs to be reopened.

[unpaid]

Hello, I am using Brave Version 1.20.103 Chromium: 88.0.4324.152 (Official Build) (64-bit) on Windows 10 Pro Version 20H2 (OS Build 19042.804) and am having the same issue, however it seems I can get the delete button to appear by making the account appear as a contact, though the button does nothing other than delete the contact. I am unsure if this functionality is intentional or not, or perhaps another bug altogether, but I encountered it while trying to delete the wallet. The steps I used to reproduce this is as follows:

1. Go to brave://wallet/
2. Click on your profile avatar
3. Click on Settings
4. Click on Contacts
5. Click on My Wallet Accounts
6. Select the wallet you want to delete
7. Click Edit
8. Click Save
9. Click on Contacts
10. Select the wallet you want to do delete
11. Click Edit

[bsclifton]

cc: @bbondy

[srirambv]

Added a note from @unpaid in #14141 so we can continue the conversation there. This issue was specifically to remove the delete button.

[ussiemer]

Now it is impossible to delete Accounts Wallets. They are just not showing? Is this the production stage?

[ranrinc]

I dont see any delete wallet button. Is this feature have been disable? Need to remove the wallet

[megmaltese]

Why is this closed?
I find it incredible that the easiest thing of all, to remove the wallet altogether, is not implemented.
And the issue here closed!
What the hell?

[bsclifton]

This issue was for the older "MetaMask" fork version of wallet (Crypto Wallet). There is a new Wallet feature in Brave which is not an extension.

Under brave://settings/wallet you can pick None for Default cryptocurrency wallet and you should be good to go

cc: @jamesmudgett

[bbondy]

Yes to the default cryptocurrency wallet setting mentioned above and you can also turn off the Show Brave Wallet icon on toolbar if you want to get rid of it

[anishp55]

how do we DELETE/REMOVE an existing wallet. not disable the whole extension. I am quite surprised this is still an issue after a year.

[Ayern12]

No.. Pada Ahd, 28 Nov 2021, 12:52 anishp55 ***@***.***> menulis:

…

how do we DELETE/REMOVE an existing wallet. not disable the whole extension. I am quite surprised this is still an issue after a year. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10999 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVINGP3FEC2AFO3J4EVFSCLUOGYPHANCNFSM4PL2WDRA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[anishp55]

no what?

[Ayern12]

Don't delete My wallet.. Pada Ahd, 28 Nov 2021, 12:55 anishp55 ***@***.***> menulis:

…

no what? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10999 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVINGP6U32DQOATEYSC5LK3UOGY2JANCNFSM4PL2WDRA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[anishp55]

no one is deleting your wallet. this is a feature request to be able to delete a wallets inside of the brave browser.

[zvikasdongre]

Any update, guys?

[afuego]

Reset the Brave wallet, make sure you back up your data.

[lumos7]

is this still not possible?