Skip to content

Upgrade from Chromium 84 to Chromium 85. #10636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkarolin opened this issue Jul 8, 2020 · 4 comments · Fixed by #10634 or brave/brave-core#6042
Closed

Upgrade from Chromium 84 to Chromium 85. #10636

mkarolin opened this issue Jul 8, 2020 · 4 comments · Fixed by #10634 or brave/brave-core#6042
Assignees
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jul 8, 2020

Upgrade from Chromium 84.0.x.y to Chromium 85.0.XX.YY

https://chromium.googlesource.com/chromium/src/+log/84.0.4147.68..85.0.4183.16/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Affected areas:

  • Download shelf
  • Translate bubble
@srirambv
Copy link
Contributor

srirambv commented Jul 9, 2020

@bsclifton should we add OS/Android label to this as a master issue for verifications?

@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Jul 9, 2020
@bsclifton
Copy link
Member

bsclifton commented Jul 9, 2020

@srirambv sure - just added OS/Android 😄

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 14, 2020

Verification passed on


Brave | 1.14.39 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
-- | --
Revision | 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified the test plan from the description

Download shelf

  • Ensured all the options Pause/Resume/Show in folder/Cancel/Open when done and Show all in download shelf works as expected
  • Ensured Clear all and Open downloads folder works as expected
  • Ensured download shelf options works fine in Normal tab, PT and TOR tabs in both light and dark mode

Light theme:
image
image

Dark theme:
image
image

Translate bubble

  • Ensured that Offer to translate pages that aren't in a language you read option is enabled by default under settings->Languages

  • Ensured that the translate bubble in shown in URL bar when the non-english site is visited https://www.deutschland.de/de
    image

  • Ensured that the google translate extension is installed after clicking on Install

  • Ensured that translate bubble isn't shown in URL bar again when the non-English site is visited again https://allegro.pl

  • Ensured that installed extension is shown under the Extensions bubble
    image

  • Ensured that websites/pages can be translated via google translate extension
    image

  • Logged and encountered [Desktop] Google translate context menu option is not shown in Brave #11268

  • Verified the extensions can be imported from other browsers and extensions displayed under the Extensions bubble
    image

  • Ensured that extensions cab be pinned and unpinned and pinned extensions displayed outside the Extensions bubble
    image

  • Ensured extensions can be removed from the Extensions bubble via Remove from Brave option
    image

  • Ensured that brave://extensions page is displayed when click on Manage extensions via Extensions bubble
    image

  • Verified all the menu options from the Extensions bubble
    image

@LaurenWags
Copy link
Member

removing release-notes/include as this is superseded by #11207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
8 participants