Skip to content

Delete most (or all) shield_exceptions.cc #10598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pes10k opened this issue Jul 7, 2020 · 0 comments · Fixed by brave/brave-core#6082
Closed

Delete most (or all) shield_exceptions.cc #10598

pes10k opened this issue Jul 7, 2020 · 0 comments · Fixed by brave/brave-core#6082
Assignees
@pes10k
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop privacy QA/No release-notes/include
Milestone
1.13.x - Release #1

Comments

@pes10k
Copy link
Contributor

pes10k commented Jul 7, 2020 •
edited
Loading

There are a bunch of hard coded exceptions for shields, mostly for webcompat reasons

https://github.com/brave/brave-core/blob/master/common/shield_exceptions.cc

Most, maybe all, of these are no longer needed, because of other system-wide web compat improvements (referrer policy changes, farbling fingerprinting improvements, etc)

This issue is to keep track of which might still be needed:

Definitely needed:

  • <nothing so far>

Maybe needed:

  • https://*.duckduckgo.com/ UA exception

Not needed:

  • all of IsBlockedResource
  • https://*.adobe.com/* UA exception
  • https://*.brave.com/* UA exception
  • https://public.tableau.com/* and https://www.arcgis.com/* fingerprinting exceptions (re @pes10k )
  • uphold.com, netverify.com, veriff.me, 1password.com and 1passwordservices.com (re @jumde )
@pes10k pes10k mentioned this issue Jul 15, 2020
Merged
32 tasks
@pes10k pes10k added feature/shields The overall Shields feature in Brave. QA/No release-notes/include labels Jul 15, 2020
@pes10k pes10k self-assigned this Jul 15, 2020
@pes10k pes10k added the privacy label Jul 15, 2020
pes10k added a commit to brave/brave-core that referenced this issue Jul 16, 2020
@pes10k
remove all shield exceptions, except for 2 remaining UA cases, fixes b…
8cc9aa4 
…rave/brave-browser#10598
@pes10k pes10k added this to the 1.13.x - Nightly milestone Jul 16, 2020
@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pes10k pes10k

Labels
feature/shields The overall Shields feature in Brave. OS/Desktop privacy QA/No release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

remove nearly all shield exceptions brave/brave-core
1 participant
@pes10k