Skip to content

[Desktop] Do not apply cosmetic filtering, in default setting, to general-purpose search web search engines that we have vetted #10575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pes10k opened this issue Jul 6, 2020 · 1 comment · Fixed by brave/brave-core#6013
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@pes10k
Copy link
Contributor

pes10k commented Jul 6, 2020

We should not apply cosmetic filterings to search engine ads, for well known, reputable, general-purpose search engines, who generally have 1p or 1p-like (re yahoo.com and yimg.com) ads.

Note that this would not change in anyway network rules / blocking, which would continue to be applied universally.

Cosmetic filtering should still be applied to these sites (and all sites) when blocking is in aggressive / max mode.

Search engines covered by this list:

  • duckduckgo.com
  • qwant.com
  • bing.com
  • startpage.com
  • yahoo.com
  • onesearch.com
  • google.com
  • yandex.com

We should also apply this cosmetic-filtering-off-by-default settings to the other eTLD+1 variants of the above.

@pes10k pes10k added feature/shields/adblock Blocking ads & trackers with Shields priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod features/shields/cosmetic-filtering OS/Desktop labels Jul 6, 2020
@pes10k pes10k changed the title [Desktop] Do not apply cosmetic filtering, in default setting, to trusted search partners [Desktop] Do not apply cosmetic filtering, in default setting, to general-purpose search web search engines that we have vetted Jul 6, 2020
@antonok-edm antonok-edm added this to the 1.12.x - Nightly milestone Jul 6, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2020

Verified passed with

Brave	1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision	e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS	macOS Version 10.14.6 (Build 18G3020)
DDG

Standard
DDG - std

Aggressive
DDG - aggressive

Qwant

Standard
Qwant - std

Aggressive
Qwant - aggressive

Bing

Standard
Bing - std

Aggressive
Bing - aggressive

Startpage

*note - confirmed thru discussions w/ @pes10k and @antonok-edm that not seeing the Ads on Startpage w/ Standard is expected. You will see them if set to Allow All. (logged/closed #10693)
Standard
Startpage - std

Aggressive
Startpage - aggressive

Yahoo

Standard
Yahoo - std

Aggressive
Yahoo - aggressive

Onesearch

Standard
onesearch - std

Aggressive
onesearch - aggressive

Google

Standard
Google - std

Aggressive
Google - aggressive

Yandex

*note - internal discussions about the Ads displaying on Yandex with Aggressive selected can be found here: https://bravesoftware.slack.com/archives/C7VLGSR55/p1594228166125900?thread_ts=1594214993.102400&cid=C7VLGSR55
Standard
Yandex - std

Aggressive
Yandex - aggressive


Verification passed on


Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Yandex

*note - internal discussions about the Ads displaying on Yandex with Aggressive selected can be found here: https://bravesoftware.slack.com/archives/C7VLGSR55/p1594228166125900?thread_ts=1594214993.102400&cid=C7VLGSR55
Standard
image

Aggressive
image

Google

Standard
image

Aggressive
image

DDG

Standard
image

Aggressive
image

Onesearch

Standard
image

Aggressive
image

Yahoo

Standard
image

Aggressive
image

Bing

Standard
image

Aggressive
image

Startpage

Standard
image

Aggressive
image

Verification passed on

Brave 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS Ubuntu 18.04 LTS
Results

duckduckgo.com
image
image
qwant.com
image
image
bing.com
image
image
startpage.com
image
image
yahoo.com
image
image
onesearch.com
image
image
google.com
image
image
yandex.com
image
image

bsclifton added a commit to brave/brave-core that referenced this issue Jan 7, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants