-
Notifications
You must be signed in to change notification settings - Fork 464
Add Version() #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Version() #175
Conversation
@bradfitz bump, although you do seem like a busy person.. 🤷♀️ |
This seems kinda nice but does need to be cleaned up. @MarcinKonowalczyk - this PR isn't super ancient so if you're up for addressing the review comment please do so. Else we'll look into it. |
f382c72
to
4d7fb7b
Compare
ty for the poke! addressed and rebased on top of master. let me know what you think. ive changed the functionality to also something to specifically point out: i think the behaviour of VersionAll ought to be to return empty strings for unconnected instances. the rationale being that just because one instance is not connected ought not to stop one learning about other instances. having said that, there is an argument to be made for a simpler api: just one |
oh, also i;ve made a tiny clarification to doc of |
Exposed the 'version' call from ping as a method on Client