[CLOSED] Add new pref maxCodeHints

[core-ai-bot]

Issue by MarcelGerber
Tuesday Nov 04, 2014 at 16:29 GMT
Originally opened as adobe/brackets#9791

---

For #9529.
I confirmed this is a performance boost for Code Hints.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/9791/commits

[core-ai-bot]

Comment by redmunds
Wednesday Nov 12, 2014 at 23:16 GMT

---

Issue #9529 is about a performance lag which it assumes is caused by the length of the code hints list. Did you do any measurements to see what's the difference with and without your changes?

It could be that most of the time is with collecting the list (which is not addressed here) as opposed to building/displaying the list (which is addressed here). Might need to pass the maxResults to the provider in the getHints() API call to get the desired improvement.

[core-ai-bot]

Comment by MarcelGerber
Thursday Nov 13, 2014 at 16:11 GMT

---

I haven't done exact measuring, but it felt faster using this branch. I used a workflow similar to the one mentioned in the issue linked above.

[core-ai-bot]

Comment by MarcelGerber
Saturday Nov 15, 2014 at 09:39 GMT

---

So, I've just measured the time _updateHintList() takes (in a test environment with q library in the folder).
With maxCodeHints=1000, it took 255 and 281 ms; with maxCodeHints=50, it took 110 and 106 ms.
That's a noticeable difference.

I wonder though if we can improve CodeHintList.update as that seems to be the performance bottleneck.

[core-ai-bot]

Comment by redmunds
Sunday Nov 16, 2014 at 22:37 GMT

---

Done with review. Yes, this is noticeably faster. Just 1 comment.

[core-ai-bot]

Comment by MarcelGerber
Wednesday Nov 19, 2014 at 16:40 GMT

---

@redmunds Ready for final review.

[core-ai-bot]

Comment by TomMalbran
Wednesday Nov 19, 2014 at 16:58 GMT

---

To improve CodeHintList.update we could use transforms instead of absolute positions and make use translatez(0) (eventually we should use the new will-change property) to make chrome use a new rendering layer for the code hints list and reduce the number of reflows.

[core-ai-bot]

Comment by redmunds
Wednesday Nov 19, 2014 at 22:58 GMT

---

@TomMalbran We're not going to expand the focus of this pull request at this point, but I'm curious as to how you think using transforms could improve performance here. The code hint list is an absolutely positioned element so it should never cause a reflow of anything else, right?

[core-ai-bot]

Comment by redmunds
Wednesday Nov 19, 2014 at 23:04 GMT

---

@MarcelGerber I wasn't sure if the validation could would handle non-numeric cases (since the value comes from a json file), so I played around with this a bit.

The good news is that all non-numeric types seems to be correctly ignored.

The bad news is that floating point numbers seem to cause a problem. When I set value to 5.5, then the number of items is rounded up to 6, which is reasonable. But, when you use up/down arrows to navigate list and go past end (which should wrap around), then the selection jumps out of the list and into the doc!

Need to add some validation code to force value to be a whole number.

[core-ai-bot]

Comment by TomMalbran
Thursday Nov 20, 2014 at 01:51 GMT

---

I wast just commenting on something@MarcelGerber said and I agree that it should be another PR.

It is actually painting a big rectangle at the bottom-left corner of the editor, that it shouldn't. Using translate should also makes it faster to calculate. Maybe the removing the box shadow could help too.

[core-ai-bot]

Comment by MarcelGerber
Thursday Nov 20, 2014 at 16:11 GMT

---

@redmunds Integer validation is in.

[core-ai-bot]

Comment by redmunds
Friday Nov 21, 2014 at 21:55 GMT

---

@TomMalbran

It is actually painting a big rectangle at the bottom-left corner of the editor, that it shouldn't.

I'm not seeing that. Open an issue if you have a recipe for it.

Maybe the removing the box shadow could help too.

I don't think@larz0 would go for that :)

[core-ai-bot]

Comment by redmunds
Friday Nov 21, 2014 at 21:55 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by redmunds
Friday Nov 21, 2014 at 21:57 GMT

---

@MarcelGerber Can you add new pref to this doc? https://github.com/adobe/brackets/wiki/How-to-Use-Brackets#preferences

[core-ai-bot]

Comment by MarcelGerber
Saturday Nov 22, 2014 at 18:40 GMT

---

@redmunds Done.

@TomMalbran I did some performance measurements and AFAICT, the real bottleneck is not the rendering, but the creation.
The jQuery loop takes much time, but I'm not sure if we can change something there.
Positioning isn't fast either.

[core-ai-bot]

Comment by TomMalbran
Sunday Nov 23, 2014 at 03:05 GMT

---

@MarcelGerber I was able to remove that loop and create the jQuery objects and pass them to Mustache when rendering the list the first time. But since I still need to create the html from jQuery I am not sure if that makes it any faster. It might get faster if we could give a formatting function to the CodeHintsList and it could use it to format just the items that were required. Maybe using React here could help too, which could allow use to use virtual scrolling.