[CLOSED] Show reason why live preview was cancelled

[core-ai-bot]

Issue by DennisKehrig
Wednesday Nov 21, 2012 at 13:04 GMT
Originally opened as adobe/brackets#2178

---

Fixes #1697

---

DennisKehrig included the following code: https://github.com/adobe/brackets/pull/2178/commits

[core-ai-bot]

Comment by njx
Monday Nov 26, 2012 at 18:18 GMT

---

Hi Dennis--in a time crunch right now so we probably won't get to this till next sprint. Thanks!

[core-ai-bot]

Comment by DennisKehrig
Wednesday Jan 30, 2013 at 11:01 GMT

---

I just rebased this onto master, I hope Github reflects this soon...

[core-ai-bot]

Comment by DennisKehrig
Monday Feb 04, 2013 at 11:22 GMT

---

"The command "git checkout -qf cc564489a918a8d13a4a644dfb15f5be0b928ec5" failed and exited with 128 during checkout."

Anything I can do?

[core-ai-bot]

Comment by DennisKehrig
Wednesday Feb 27, 2013 at 10:56 GMT

---

My Chrome is now at 25.0.1364.97 m and sends the dispatched event! Rebased the pull request onto master.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 06, 2013 at 12:41 GMT

---

Rebased

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 16:42 GMT

---

Rebased once more - should another be necessary, I'll wait until prompted.

[core-ai-bot]

Comment by njx
Tuesday Mar 19, 2013 at 18:05 GMT

---

Sorry I haven't gotten back to this. Will try to work on it this sprint.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 21:08 GMT

---

Cool, thanks! Did another rebase anyway, to get rid of my unnecessary dealing with the Chinese translation + Windows git issues.

[core-ai-bot]

Comment by njx
Wednesday Mar 20, 2013 at 21:10 GMT

---

Finally getting around to this. The error really helps, and I like the basic interaction. However, I ran into a problematic scenario: if the live preview browser overlaps the Brackets window (which is likely on a laptop, especially if you make it bigger in order to use the dev tools), and you spend a little time in the dev tools before switching back to Brackets, you'll never see the twipsy because it fades out before you switch back. We should make it so that if the Brackets window isn't active when the twipsy comes up, it doesn't fade out until after Brackets becomes active again. Could you look into making that change?

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 27, 2013 at 22:02 GMT

---

Sounds reasonable, I'll look into it!

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 22:39 GMT

---

@njx Done! Note that I put the window focus detection into twipsy-mod. I first wanted to add it to ViewUtils, but this would have made the jQuery module dependent on it. This way it seemed cleaner - until some other part of the system needs the same. Also I tried it via document.hasFocus() but that returned true even when the Brackets window was not the foreground window.

[core-ai-bot]

Comment by njx
Friday Apr 05, 2013 at 20:31 GMT

---

Detailed review done. The only substantive issue is the one about the error showing up when the user turns off Live Preview him/herself--we should fix that before merging. Otherwise, looks good.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Apr 09, 2013 at 10:19 GMT

---

@njx: Thanks for the review! I think it's new behaviour that the popup also appears when the user closes live preview... could be a timing issue where we close the tab before we (would have) cut the connection ourselves.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Apr 09, 2013 at 10:35 GMT

---

Hmmm. It appears that usually we are still connected after the window closes, so we do close the connection ourselves. Yet the popup appears. Maybe something changed on Chrome's end.
But it's good that it's this way around, it allows us to set a flag in some way before disconnecting, so we can ignore the detached event in that stage.

[core-ai-bot]

Comment by DennisKehrig
Tuesday Apr 09, 2013 at 10:37 GMT

---

Another thing that should be added is a popup if we close the connection ourselves because the user navigates away from the page. On the other hand we might rethink that; if I accidentally click a click and navigate back right away, I'd prefer live preview to still be active.