[CLOSED] update codemirror to 5.24.0

[core-ai-bot]

Issue by zaggino
Monday Feb 20, 2017 at 23:54 GMT
Originally opened as adobe/brackets#13116

---

contains various TypeScript improvements (among others) that I'd like to see in master since this upgrade is not doable through an extension

cc@ficristo@petetnt@swmitra

---

zaggino included the following code: https://github.com/adobe/brackets/pull/13116/commits

[core-ai-bot]

Comment by swmitra
Tuesday Feb 21, 2017 at 06:37 GMT

---

This upgrade bring quite a few bug fixes accumulated through 22, 23 and 24. I would also like to see use of sticky prop in position. Good upgrade for Brackets 1.9 👍

[core-ai-bot]

Comment by ficristo
Tuesday Feb 21, 2017 at 07:19 GMT

---

This breaks a lot of tests. You need to change them to consider the new sticky property.

[core-ai-bot]

Comment by swmitra
Tuesday Feb 21, 2017 at 08:20 GMT

---

Yes@ficristo. For now to leverage on the bug fixes and mode optimizations we can just upgrade the CM version, but to actually use the new features we need a complete development cycle which we can't have for Brackets 1.9. Do let us know if you think that this upgrade alone might cause problems.

[core-ai-bot]

Comment by ficristo
Tuesday Feb 21, 2017 at 08:45 GMT

---

For what I looked we only need to adjust our tests.
This only mean that before we checked for {line: x: ch:y} now we need to check for {line: x: ch:y, sticky: null}. We don't use new features.
Hopefully this is the only change for all breaking tests.

[core-ai-bot]

Comment by zaggino
Wednesday Feb 22, 2017 at 02:21 GMT

---

I believe I have resolved test issues, can you please re-check guys?

[core-ai-bot]

Comment by swmitra
Wednesday Feb 22, 2017 at 05:24 GMT

---

Restarted the travis build and all checks are successful. Waiting for@ficristo to approve this PR and we can merge then.

[core-ai-bot]

Comment by ficristo
Wednesday Feb 22, 2017 at 08:44 GMT

---

There were still some failures on extensions tests.
(There were other failures but probably related to my system)

[core-ai-bot]

Comment by ficristo
Wednesday Feb 22, 2017 at 14:18 GMT

---

I just noticed 5.24.2 was released. Better upgrade to it.

[core-ai-bot]

Comment by zaggino
Thursday Feb 23, 2017 at 06:53 GMT

---

Upgraded to 5.24.2, sadly something is not right with unit testing on my machine. Some tests do randomly pass and fail and then I try to open developer tools to debug, the whole testing window just freezes, quite terrible development experience.

[core-ai-bot]

Comment by swmitra
Thursday Feb 23, 2017 at 07:50 GMT

---

I will also try to see if I can run the tests and figure out any particular issue@zaggino.

[core-ai-bot]

Comment by zaggino
Thursday Feb 23, 2017 at 07:59 GMT

---

thanks, yesterday all integration tests were passing with this PR and now they are randomly failing, drives me mad but i'll give it a try again probably tomorrow

[core-ai-bot]

Comment by zaggino
Saturday Feb 25, 2017 at 00:13 GMT

---

fixed (hopefully all) extension unit tests,@ficristo can you please have a look and let me know which (if any) particular tests still fail because of this PR?

[core-ai-bot]

Comment by ficristo
Monday Feb 27, 2017 at 19:59 GMT

---

It seems there are still some failures with Extensions \ JavaScript Code Hinting and Extensions \ JSQuickEdit.
NOTE: I reverted 7883b0134b9923418632bf01ad48849aa8c14d2e before testing. See adobe/brackets#13126

[core-ai-bot]

Comment by zaggino
Tuesday Feb 28, 2017 at 04:23 GMT

---

@ficristo fixed those tests, also added a fix for #13126 - adobe/brackets@1de6b88?w=1

[core-ai-bot]

Comment by ficristo
Tuesday Feb 28, 2017 at 09:27 GMT

---

Thank you for all the effort.