[CLOSED] fixes 3 failing find-in-files tests

[core-ai-bot]

Issue by zaggino
Friday Dec 09, 2016 at 03:05 GMT
Originally opened as adobe/brackets#12973

---

this PR fixes:

should add matches for a new file
should remove matches for a deleted file
should remove matches for a deleted folder

on my windows machine
ref: adobe/brackets#12951

---

zaggino included the following code: https://github.com/adobe/brackets/pull/12973/commits

[core-ai-bot]

Comment by ficristo
Saturday Dec 10, 2016 at 09:47 GMT

---

The test should close the panel and detach listeners if a file is modified on disk is still failing for me.
I suppose it needs a different fix.

should do a case-sensitive search/replace from find bar was failing even before, so it's fine (for now).

[core-ai-bot]

Comment by zaggino
Saturday Dec 10, 2016 at 12:59 GMT

---

Yeah, one test at a time I guess... I'll check what can fix the others next week when I'll have some free time.

[core-ai-bot]

Comment by zaggino
Monday Dec 12, 2016 at 22:07 GMT

---

@ficristo ready to merge this one, i'll open another if I manage to fix other tests