Allow restore network to have network connectivity #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods for checkpointing and restoring containers were added to the native driver. The LXC driver returns an error message that these methods are not implemented yet. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: daemon/execdriver/native/create.go daemon/execdriver/native/driver.go daemon/execdriver/native/init.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Support was added to the daemon to use the Checkpoint and Restore methods of the native exec driver for checkpointing and restoring containers. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: api/server/server.go daemon/container.go daemon/daemon.go daemon/networkdriver/bridge/driver.go daemon/state.go vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
Restore failed if network resource not released during checkpoint, e.g., a container with port open with -p Signed-off-by: Hui Kang <[email protected]> Conflicts: daemon/container.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Add a basic test for checkpoint/restore to the integration tests Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Hui Kang <[email protected]> (github: huikang)
Docker-DCO-1.1-Signed-off-by: Mark Oates [email protected] (github: fl0yd)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
…efault. Signed-off-by: Ross Boucher <[email protected]>
Signed-off-by: Ross Boucher <[email protected]>
Reuse the endpoint of the checkpointed container when restore. Pass veth pair name to ciur when restore a checkpointed container. Signed-off-by: Hui Kang <[email protected]>
This was referenced Sep 21, 2015
Closed
boucher
force-pushed
the
cr-combined
branch
2 times, most recently
from
8fd276b to
eeff94a
Compare
|
hey @huikang, I had to rebase again, and unfortunately this code no longer works. Even adapted to use moby/libnetwork#518, the network no longer functions after a restore. I haven't been able to track down the problem yet. |
|
@boucher Thanks for letting me know. I will look at the problem soon. |
boucher
force-pushed
the
cr-combined
branch
3 times, most recently
from
5dda3d1 to
183488f
Compare
|
Ok, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the endpoint of the checkpointed container when restore.
Pass veth pair name to ciur when restore a checkpointed container.
Signed-off-by: Hui Kang [email protected]