Skip to content

Fix kwallet again #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix kwallet again #900

wants to merge 4 commits into from

Conversation

samuel-w
Copy link
Contributor

One last try to fixing kwallet. If this doesn't work just remove the kwallet code, its causing more bugs than solutions.

Slightly based it off python-keyring's implementation, https://github.com/jaraco/keyring/blob/main/keyring/backends/kwallet.py#L96.

@samuel-w
Copy link
Contributor Author

Wait, why don't we just use python-keyring?

@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #900 (0d6e0ec) into master (84c3d3c) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   70.32%   70.31%   -0.02%     
==========================================
  Files          56       56              
  Lines        3791     3793       +2     
==========================================
+ Hits         2666     2667       +1     
- Misses       1125     1126       +1     
Impacted Files Coverage Δ
src/vorta/keyring/kwallet.py 52.50% <16.66%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c3d3c...0d6e0ec. Read the comment docs.

This reverts commit b22379c.
@m3nu
Copy link
Contributor

m3nu commented Feb 27, 2021

Doesn't change the functionality of the code, right? Just re-arranges a few things.

@m3nu
Copy link
Contributor

m3nu commented Feb 27, 2021

Wait, why don't we just use python-keyring?

We did in the beginning, but there were other issues, like Pyobjc segfaults.

#190 (comment)

m3nu added a commit to m3nu/vorta that referenced this pull request Feb 27, 2021
@m3nu
Copy link
Contributor

m3nu commented Feb 27, 2021

Thanks, cherry-picked a change into #898.

@m3nu m3nu closed this Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants