-
Notifications
You must be signed in to change notification settings - Fork 158
Reload database when extracting database over it #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2320570
Fix crash when restoring settings.db
samuel-w 2024e7d
Reconnect only on extract
samuel-w 4b4ac84
Remove extra message
samuel-w f8d0dad
Comment
samuel-w bdc580d
Apply changes from 'BackupRestore'
samuel-w 435e5da
Add tab reloading
samuel-w 1c5eeac
Merge branch 'master' into db_readonly
samuel-w 303a39d
Use click instead of setChecked
samuel-w 131d757
Merge branch 'db_readonly' of github:samuel-w/vorta-1 into db_readonly
samuel-w f39627f
Merge branch 'master' into db_readonly
samuel-w 8d7d3b8
Merge branch 'master' into db_readonly
samuel-w 0a5f1cc
Trigger refresh when db likely extracted
samuel-w c58d40f
Add log message
samuel-w 622543e
Merge branch 'master' into db_readonly
samuel-w 453abf8
Make tests go brrrrr
samuel-w b533faf
Reorder if in descending likeliness
samuel-w 3029328
Remove connect_db
samuel-w c53a37a
Revert "Remove connect_db"
samuel-w 2226a80
Merge branch 'master' into db_readonly
samuel-w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not have
init_db()
only?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump. Is
connect_db()
even needed? Why not move it all toinit_db()
? For tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried to remove it and it broke the tests. I could try to change the test code, but based on past experience changing it makes things worse.