Skip to content

borg import-tar hangs #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drewkett opened this issue Mar 4, 2022 · 0 comments
Closed

borg import-tar hangs #6401

drewkett opened this issue Mar 4, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@drewkett
Copy link

drewkett commented Mar 4, 2022

Have you checked borgbackup docs, FAQ, and open Github issues?

Yes

Is this a BUG / ISSUE report or a QUESTION?

BUG

System information. For client/server mode post info for both machines.

Your borg version (borg -V).

1.2.0

Operating system (distribution) and version.

arch linux (up to date as of 2022-03-04)

Hardware / network configuration, and filesystems used.

VM using local files on btrfs fs

How much data is handled by borg?

~500MB

Full borg commandline that lead to the problem (leave away excludes and passwords)

borg import-tar -p -s path_to_repo::archive_name filename.tar.zstd

Describe the problem you're observing.

The command was hanging without any output. I think it is an error due to the archive already existing but not properly propagating back to user. If I unzstd the file before, and try it with an uncompressed tar file it correctly gives Archive archive_name already exists

Can you reproduce the problem? If so, describe how. If not, describe troubleshooting steps you took before opening the issue.

Try running import-tar with a zstd compressed tar file when the archive_name already exists in the repo

@ThomasWaldmann ThomasWaldmann added this to the 1.1.18 milestone Mar 4, 2022
@ThomasWaldmann ThomasWaldmann self-assigned this Mar 4, 2022
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 4, 2022
in the finally-block, we wait for the filter process to die. but it only dies
voluntarily if all data was processed by the filter and it terminates due to EOF.

otoh, if borg has thrown an early exception, e.g. "archive already exists",
we need to kill the filter process to bring it to an early end. in that
case, we also do not need to check the filter rc, because we know we killed it.
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 4, 2022
in the finally-block, we wait for the filter process to die. but it only dies
voluntarily if all data was processed by the filter and it terminates due to EOF.

otoh, if borg has thrown an early exception, e.g. "archive already exists",
we need to kill the filter process to bring it to an early end. in that
case, we also do not need to check the filter rc, because we know we killed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants