-
Notifications
You must be signed in to change notification settings - Fork 662
Add missing "return" #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing "return" #3020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3020 +/- ##
===========================================
- Coverage 93.11% 93.09% -0.03%
===========================================
Files 176 176
Lines 13647 13647
===========================================
- Hits 12708 12704 -4
- Misses 939 943 +4 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
@DockedFerret800, thank you for the PR. There are similar issues in a few other examples as well. Could you please go ahead and fix those as part of this commit? |
Sure |
I think these are all I was able to find. |
Thanks, please squash them into a single commit if possible. |
I'll recreate a PR. |
Commit messages are even better when they start with nouns instead of verbs: "examples use return statements where needed" |
I'll remember that for the future. Thank you! |
Hi. Aren't we supposed to return in case of an error? Similarly to what we do in other examples, for example in
websocket_server_async_local.cpp
.