Skip to content

Add missing "return" #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

DockedFerret800
Copy link
Contributor

Hi. Aren't we supposed to return in case of an error? Similarly to what we do in other examples, for example in websocket_server_async_local.cpp.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (1fc5512) to head (415bf82).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3020      +/-   ##
===========================================
- Coverage    93.11%   93.09%   -0.03%     
===========================================
  Files          176      176              
  Lines        13647    13647              
===========================================
- Hits         12708    12704       -4     
- Misses         939      943       +4     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc5512...415bf82. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashtum
Copy link
Collaborator

ashtum commented Jul 24, 2025

@DockedFerret800, thank you for the PR. There are similar issues in a few other examples as well. Could you please go ahead and fix those as part of this commit?

@DockedFerret800
Copy link
Contributor Author

@DockedFerret800, thank you for the PR. There are similar issues in a few other examples as well. Could you please go ahead and fix those as part of this commit?

Sure

@DockedFerret800
Copy link
Contributor Author

I think these are all I was able to find.

@ashtum
Copy link
Collaborator

ashtum commented Jul 24, 2025

Thanks, please squash them into a single commit if possible.

@DockedFerret800
Copy link
Contributor Author

I'll recreate a PR.

@vinniefalco
Copy link
Member

Commit messages are even better when they start with nouns instead of verbs:

"examples use return statements where needed"

@DockedFerret800
Copy link
Contributor Author

Commit messages are even better when they start with nouns instead of verbs:

"examples use return statements where needed"

I'll remember that for the future. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants