Feature: 다시보기 완성 #299
Merged
Feature: 다시보기 완성 #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
서버에서 받아온 데이터로 다시보기를 확인 할 수 있습니다.
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LellowMellow
approved these changes
Dec 14, 2023
Comment on lines
+84
to
90
| console.log(result.data.logs); | ||
| loadedDataRef.current = result.data.logs; | ||
| scriptListRef.current = result.data.subtitles; | ||
| localAudioRef.current!.src = result.data.audio_file; | ||
| localAudioRef.current!.addEventListener("loadedmetadata", () => { | ||
| totalTimeRef.current = localAudioRef.current!.duration * 1000; | ||
| }); |
There was a problem hiding this comment.
지금은 크게 중요한건 아니지만... 크롱님이 남겨주셨던 코드리뷰가 떠오르네요.. ㅎㅎㅎ 구조분해할당으로 한 번만 객체의 요소에 접근하도록 하는 것도 하나의 방법일 것 같습니다. 나중에 같이 개선해봐요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
서버에서 받아온 데이터로 다시보기를 확인 할 수 있습니다.
작업 개요
다시보기 데이터를 서버에서 받아서 실행 할 수 있습니다.
작업 사항
스크린샷
55.mp4