Skip to content

Fix: 프로그래스 바 마우스 다운 이벤트 발생 시 사라지는 버그 해결 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Byeonjin
Copy link
Collaborator

작업 개요

프로그래스 바 마우스 다운 이벤트 발생 시 사라지는 버그 해결

작업 사항

원인: 드래그 기능 구현 초기에 프로그래스 바의 너비 조절이 딜레이가 생겨 그 문제를 해결하는 과정에서 남아있던 레거시 코드에 의해 버그가 발생했습니다.

고민한 점들(필수 X)

스크린샷(필수 X)

@Byeonjin Byeonjin added 🐞 Fix 버그 수정 FE 프론트엔드 작업 labels Dec 13, 2023
@Byeonjin Byeonjin added this to the 6주차 milestone Dec 13, 2023
@Byeonjin Byeonjin self-assigned this Dec 13, 2023
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for boarlog ready!

Name Link
🔨 Latest commit 2a10a99
🔍 Latest deploy log https://app.netlify.com/sites/boarlog/deploys/657980420f82840008ead2ba
😎 Deploy Preview https://deploy-preview-294--boarlog.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@LellowMellow LellowMellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 고생하셨습니다~~

Copy link
Collaborator

@Jw705 Jw705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 👍👍

@@ -137,7 +135,7 @@ const ProgressBar = ({
<div className="relative grow h-[6px] bg-grayscale-lightgray">
<div
className={`absolute top-0 left-0 h-[6px] w-[0%] bg-boarlog-100`}
style={{ width: isProgressBarDrag ? "" : `${getPercentOfProgress(progressMsTime, totalTime)}` }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기가 문제였군요!

@Byeonjin Byeonjin merged commit 952c473 into boostcampwm2023:dev Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 작업 🐞 Fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants