Refactor(#288): Example 페이지 제거, 불필요한 routing 제거 #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- release 시에 불필요한 routing과 example 페이지를 제거하였습니다.
- userauth로 routing이 변경됨에 따라서 이동하는 주소를 수정하였습니다.
- Guest로 서비스를 이용할 수 있도록 문구를 수정하고 이동하도록 처리하였습니다.
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LellowMellow
changed the title
Byeonjin
reviewed
Dec 13, 2023
Comment on lines
+5
to
+14
| const navigate = useNavigate(); | ||
| const showToast = useToast(); | ||
| const handleButtonClicked = () => { | ||
| showToast({ message: "Guest로 시작합니다.", type: "default" }); | ||
| navigate("/"); | ||
| }; | ||
|
|
||
| return ( | ||
| <button type="button" className="medium-16"> | ||
| Boarlog 체험하기 | ||
| <button type="button" className="medium-16" onClick={handleButtonClicked}> | ||
| Guest로 시작하기 |
Byeonjin
reviewed
Dec 13, 2023
| @@ -5,7 +5,7 @@ const HeaderLogo = ({ type, lectureTitle }: { type: "login" | "normal" | "lectur | |||
| const navigate = useNavigate(); | |||
|
|
|||
| const handleLogoClicked = () => { | |||
| if (type === "login") navigate("/login"); | |||
| if (type === "login") navigate("/userauth"); | |||
There was a problem hiding this comment.
기존에 꼭 있었으면 했던 기능이었는데 좋네요!
Byeonjin
approved these changes
Dec 13, 2023
Jw705
approved these changes
Dec 13, 2023
| @@ -25,12 +23,10 @@ const App = () => { | |||
| <Route path="/userauth" element={<UserAuth />} /> | |||
| <Route path="/start" element={<Start />} /> | |||
| <Route path="/mypage" element={<MyPage />} /> | |||
| <Route path="/test" element={<Test />} /> | |||
There was a problem hiding this comment.
test 페이지는 나중에 미디어 서버가 종료되었을 때(크레딧 소진 등..)를 위해서 발표 후에 살려봐도 좋을 것 같습니다!
| <button type="button" className="medium-16"> | ||
| Boarlog 체험하기 | ||
| <button type="button" className="medium-16" onClick={handleButtonClicked}> | ||
| Guest로 시작하기 |
There was a problem hiding this comment.
혹시 게스트일 때는 메인 페이지에서 강의 시작하기 카드가 보이지 않게 처리하는 건 너무 오래걸릴까요..?
There was a problem hiding this comment.
아하 완전 막는 방식인가요? 그리 오래 걸리지는 않을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
작업 사항
고민한 점들(필수 X)
release 이전에 서비스 이용 중에 발생할 수 있는 불편함을 해소하고자 일부 코드를 수정하였습니다.