Skip to content

Fix: 메모지 추가 버그 해결 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Byeonjin
Copy link
Collaborator

작업 개요

메모지 추가 버그 해결

작업 사항

  • 질문 메모가 아닌데도 소켓에 solved 이벤트를 발생시켜 questionId가 없는데도 보내 에러가 발생한다

고민한 점들(필수 X)

스크린샷(필수 X)

추가사항

질문 채팅창에 사용자 닉네임이나 Guest가 표시되도록 변경했습니다.

- 질문 메모가 아닌데도 solved 이벤트를 발생시켜 questionId가 없는데도 보내 에러가 발생한다.
@Byeonjin Byeonjin added ✨ Feat 기능 개발 🐞 Fix 버그 수정 🛠️ Refactor 리팩토링 작업 FE 프론트엔드 작업 labels Dec 13, 2023
@Byeonjin Byeonjin added this to the 6주차 milestone Dec 13, 2023
@Byeonjin Byeonjin self-assigned this Dec 13, 2023
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for boarlog ready!

Name Link
🔨 Latest commit 406227a
🔍 Latest deploy log https://app.netlify.com/sites/boarlog/deploys/65795da4af77f000081bea70
😎 Deploy Preview https://deploy-preview-286--boarlog.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@LellowMellow LellowMellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guest에 대한 코드도 추가되었군요! 고생 많으셨습니다 :)

@Byeonjin Byeonjin merged commit f556a58 into boostcampwm2023:dev Dec 13, 2023
Copy link
Collaborator

@Jw705 Jw705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 😊

@Jw705 Jw705 removed the FE 프론트엔드 작업 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 기능 개발 🐞 Fix 버그 수정 🛠️ Refactor 리팩토링 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants