Refactor(#249): 링크 공유 개선, Toast state 분리 #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 클립보드 공유의 method를 따로 분리하고, env에서 url을 가져오도록 수정하였습니다.
- toast state 관련 파일을 src/stores로 이동하였습니다.
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jw705
approved these changes
Dec 11, 2023
| @@ -1,6 +1,6 @@ | |||
| import { useState, useEffect } from "react"; | |||
| import { useRecoilState } from "recoil"; | |||
| import { toastListState } from "./toastAtom"; | |||
| import { toastListState } from "../../stores/stateToastList"; | |||
There was a problem hiding this comment.
Suggested change
| import { toastListState } from "../../stores/stateToastList"; | |
| import { toastListState } from "@/stores/stateToastList"; |
위의 주소처럼 통일하는 것은 어떤가요?
There was a problem hiding this comment.
수정하는게 좋겠네요! 감사합니다 :)
Byeonjin
reviewed
Dec 11, 2023
| await navigator.clipboard.writeText( | ||
| `[함께 듣는 실시간 강의 Boarlog]\n\n지금 진행되는 강의에 참여해 보세요.\n\n강의 코드: ${lectureCode}\n강의 제목: 화이트보드 테스트\n강의 링크: https://dev--boarlog.netlify.app/participant?roomid=${lectureCode}` | ||
| ); | ||
| await navigator.clipboard.writeText(getClipboardText(lectureCode)); |
- ToastContainer의 상대 경로를 수정하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
작업 사항
고민한 점들(필수 X)
현재 프로젝트는
dev와main으로local/dev/production로 페이즈를 나누어 개발중에 있습니다. 강의 코드를 클립보드에 복사하여 링크를 공유하는 과정에서base-url이 달라야 하기 때문에 이를 위해env로 값을 달리하여 각 페이즈마다의 공유 링크를 가지도록 하였습니다.추가적으로 state를 한 곳에 모아 관리하기 위해
Toast의 recoil state 관련 파일을src/stores로 이동하여 구조 개선 작업을 시작하였습니다. (naming convention에 맞게 이름을 변경하였습니다.)스크린샷(필수 X)
(뷰 변경사항 없음)