Skip to content

Refact: 이미지 버튼 제거 및 메모지 회전, 크기 조절 기능 제거 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Byeonjin
Copy link
Collaborator

@Byeonjin Byeonjin commented Dec 7, 2023

작업 개요

  • 이미지 버튼 제거
  • 메모 회전, 크기 조절 기능 제거

작업 사항

  • 이미지 버튼 제거
  • 메모 회전, 크기 조절 기능 제거

고민한 점들(필수 X)

스크린샷(필수 X)

2023-12-07.7.06.28.mov

@Byeonjin Byeonjin added 🛠️ Refactor 리팩토링 작업 FE 프론트엔드 작업 labels Dec 7, 2023
@Byeonjin Byeonjin added this to the 5주차 milestone Dec 7, 2023
@Byeonjin Byeonjin self-assigned this Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for boarlog ready!

Name Link
🔨 Latest commit b645f8e
🔍 Latest deploy log https://app.netlify.com/sites/boarlog/deploys/657198e79c842f00084f4b39
😎 Deploy Preview https://deploy-preview-228--boarlog.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Byeonjin Byeonjin marked this pull request as ready for review December 7, 2023 09:39
@Byeonjin Byeonjin changed the title Refact: 이미지 버튼 제거 Refact: 이미지 버튼 제거 및 메모지 회전, 크기 조절 기능 제거 Dec 7, 2023
Copy link
Collaborator

@Jw705 Jw705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@@ -37,7 +37,7 @@ export const getStickyNoteInstance = (
strokeWidth: 1
});

const stickyMemo = new fabric.Group([note, text]);
const stickyMemo = new fabric.Group([note, text], { hasControls: false });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

회전, 크기 조절 제거한 거 좋은 생각인 것 같습니다!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 너무 좋습니다!! :)

Copy link
Collaborator

@LellowMellow LellowMellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 읽었습니다!! 마지막까지 화이팅 🔥🔥🔥🔥

@@ -37,7 +37,7 @@ export const getStickyNoteInstance = (
strokeWidth: 1
});

const stickyMemo = new fabric.Group([note, text]);
const stickyMemo = new fabric.Group([note, text], { hasControls: false });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 너무 좋습니다!! :)

@Byeonjin Byeonjin merged commit 9aeade7 into boostcampwm2023:dev Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 작업 🛠️ Refactor 리팩토링 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants