Refactor(#217): 화이트보드-backspace로 그래픽 요소 지우기 구현 #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jw705
approved these changes
Dec 7, 2023
| @@ -68,7 +68,8 @@ const CanvasSection = () => { | |||
| window.addEventListener("resize", handleResize); | |||
|
|
|||
| // delete 키를 이용해서 선택된 객체 삭제 | |||
| const handleDelete = () => { | |||
| const handleDelete = ({ key, code }: { key: string; code: string }) => { | |||
| if (!(code === "Delete" || key === "Delete" || code === "Backspace" || key === "Backspace")) return; | |||
| @@ -95,6 +92,7 @@ const CanvasSection = () => { | |||
| return () => { | |||
| newCanvas.dispose(); | |||
| window.removeEventListener("resize", handleResize); | |||
| window.removeEventListener("keyup", handleDelete); | |||
LellowMellow
approved these changes
Dec 7, 2023
| @@ -68,7 +68,8 @@ const CanvasSection = () => { | |||
| window.addEventListener("resize", handleResize); | |||
|
|
|||
| // delete 키를 이용해서 선택된 객체 삭제 | |||
| const handleDelete = () => { | |||
| const handleDelete = ({ key, code }: { key: string; code: string }) => { | |||
| if (!(code === "Delete" || key === "Delete" || code === "Backspace" || key === "Backspace")) return; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
화이트보드-backspace로 그래픽 요소 지우기 구현 close #217
작업 사항
고민한 점들(필수 X)
스크린샷(필수 X)