Feature(#42): 강의 참여 페이지 채팅 사이드바를 사용자가 확인할 수 있다 (UI 작업) #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 접근성을 위해 input에 label을 연결해야 하는데, 이 label의 텍스트를 디자인을 위해 숨기기만 하기위한 스타일입니다
- 채팅 사이드바 UI 작업 - 채팅 공백시 버튼 비활성화 기능 구현
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jw705
approved these changes
Dec 4, 2023
| }; | ||
|
|
||
| interface LogContainerInterface { | ||
| type: "question" | "prompt"; |
There was a problem hiding this comment.
type: "prompt"는 언제 사용되는 건가요?
| className: string; | ||
| } | ||
|
|
||
| const QuestionPromptLogContainer = ({ type, className }: LogContainerInterface) => { |
There was a problem hiding this comment.
QuestionPromptLogContainer라는 이름 대신 QuestionContainer는 어떠신가요? 확장성을 고려해서 ChatContainer라는 이름도 좋아보입니다!
LellowMellow
approved these changes
Dec 5, 2023
Comment on lines
+125
to
+137
|
|
||
| .a11y-hidden { | ||
| overflow: hidden; | ||
| position: absolute; | ||
| clip: rect(0, 0, 0, 0); | ||
| clip-path: circle(0); | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| border: 0; | ||
| padding: 0; | ||
| white-space: nowrap; | ||
| } |
There was a problem hiding this comment.
신기하네요 :) 관련 내용을 시각적으로는 숨겨놓는 용도군요
| @@ -15,7 +16,10 @@ const Participant = () => { | |||
| return ( | |||
| <> | |||
| <Header type="participant" /> | |||
| <video className="relative w-[100vw] h-[calc(100vh-6rem)]" autoPlay muted ref={videoRef}></video> | |||
| <section className="relative"> | |||
| <video className="w-[100vw] h-[calc(100vh-6rem)]" autoPlay muted ref={videoRef}></video> | |||
There was a problem hiding this comment.
여기 5rem으로 수정해주시면 될 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
채팅 사이드바 UI 구현 close #42
작업 사항
고민한 점들(필수 X)
스크린샷(필수 X)
2023-12-04.9.46.15.mov