-
Notifications
You must be signed in to change notification settings - Fork 0
Feature(#24): Error 페이지, 강의 종료 페이지 구현 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LellowMellow
merged 4 commits into
boostcampwm2023:dev
from
LellowMellow:feature/231204-add-404-page
Dec 5, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { useNavigate } from "react-router-dom"; | ||
import LogoBig from "@/assets/imgs/logoBig.png"; | ||
import Button from "@/components/Button/Button"; | ||
import HomeIcon from "@/assets/svgs/home.svg?react"; | ||
|
||
const Error = () => { | ||
const navigate = useNavigate(); | ||
|
||
return ( | ||
<div className="flex flex-col items-center justify-center display-center w-11/12 sm:8/12 md:w-fit"> | ||
<div className="flex flex-row items-center justify-center"> | ||
<p className="font-pretendard font-bold text-8xl md:text-size-260">4</p> | ||
<img src={LogoBig} className="w-24 h-24 md:w-fit md:h-fit" alt="로고 이미지" /> | ||
<p className="font-pretendard font-bold text-8xl md:text-size-260">4</p> | ||
</div> | ||
<p className="font-pretendard font-semibold text-size-32 md:text-size-64">NOT FOUND</p> | ||
<p className="semibold-20 text-grayscale-darkgray mt-12 mb-6">이런! 잘못된 접근이에요.</p> | ||
<Button type="full" buttonStyle="black" onClick={() => navigate("/")}> | ||
<HomeIcon className="fill-grayscale-white" />홈 화면으로 돌아가기 | ||
</Button> | ||
</div> | ||
); | ||
}; | ||
|
||
export default Error; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { useNavigate } from "react-router-dom"; | ||
import EndLecture from "@/assets/imgs/endLecture.png"; | ||
import Button from "@/components/Button/Button"; | ||
import HomeIcon from "@/assets/svgs/home.svg?react"; | ||
|
||
const LectureEnd = () => { | ||
const navigate = useNavigate(); | ||
|
||
return ( | ||
<div className="flex flex-col items-center justify-center display-center w-11/12 md:w-fit"> | ||
<img src={EndLecture} className="w-64 h-64 md:w-fit md:h-fit" alt="로고 이미지" /> | ||
<p className="font-pretendard font-semibold text-size-32 -mt-20 md:-mt-32 md:text-size-64">CLOSED</p> | ||
<p className="semibold-20 text-grayscale-darkgray mt-12 mb-6">강의가 종료되었어요.</p> | ||
<Button type="full" buttonStyle="black" onClick={() => navigate("/")}> | ||
<HomeIcon className="fill-grayscale-white" />홈 화면으로 돌아가기 | ||
Comment on lines
+12
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 페이지 디자인 너무 귀엽습니다. ㅋㅋㅋㅋㅋ |
||
</Button> | ||
</div> | ||
); | ||
}; | ||
|
||
export default LectureEnd; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이름에서 조금 혼동이 올 수 있을 것 같은데 ErrorPage라는 이름은 어떠신가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다! 수정해보겠습니다 :)