Skip to content

Added notice that facial detection is occurring #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

mrkmg
Copy link
Contributor

@mrkmg mrkmg commented Jan 2, 2019

Added a pam conversation message that the facial detection is being performed.

Why?

In my setup, my webcam is not always "front and center". I often use external monitors on my laptop and my webcam ends up pointing toward the side of my face. In order to get face detection to work, I need to turn my head and look into the webcam.

I find myself forgetting to turn and look at the webcam when typing sudo from the command line. Then I either type my password or canceling it and trying again.

I added this message on my machine, and it works great to remind me to look at the webcam.

Added a pam conversation message that the facial detection is being performed.
@boltgolt
Copy link
Owner

boltgolt commented Jan 2, 2019

Thanks for adding your work back into Howdy!
Because this is new behavior that all users will see after the update to 2.5.0, i would rather have that it could be turned on or off with a config value. Would you be comfortable with adding a value to the [core] section of the config file?

@boltgolt boltgolt added this to the Release 2.5.0 milestone Jan 3, 2019
@mrkmg
Copy link
Contributor Author

mrkmg commented Jan 4, 2019

I assume we want this to be config off by default?

@boltgolt boltgolt changed the base branch from master to dev January 4, 2019 23:44
@boltgolt boltgolt merged commit 6e10851 into boltgolt:dev Jan 5, 2019
@boltgolt
Copy link
Owner

boltgolt commented Jan 6, 2019

Thanks a lot!

@mrkmg mrkmg deleted the add-checking-notification branch January 6, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants