Force import line wrap by count and line length #13626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
added
status: ready
type: task
tag: codebase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13626 +/- ##
===========================================
Coverage 92.54% 92.54%
===========================================
Files 323 323
Lines 20493 20493
===========================================
Hits 18965 18965
Misses 1528 1528 |
bryevdv
reviewed
Dec 31, 2023
bryevdv
approved these changes
Dec 31, 2023
mattpap
force-pushed
the
mattpap/isort_wrap_length
branch
from
e4aeca1 to
0ecde82
Compare
bryevdv
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Make line_length cutoff consistent at 88 * Update the codebase * Use relative imports to shorten line lengths
bryevdv
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Make line_length cutoff consistent at 88 * Update the codebase * Use relative imports to shorten line lengths
bryevdv
added a commit
that referenced
this pull request
Jan 25, 2024
* Log figure render count and start/end (#13503) * Log PlotView render count * Include model id in render console messages * remove new code annotations * test logger trace * implement log level trace handling * remove extra semicolons apply suggested message * apply suggested message --------- Co-authored-by: Ian Thomas <[email protected]> * Update CoC to use reporting form (#13647) * Let client ping failure clean up session (#13655) * Let client ping failure clean up session * Fix typo * Add test * Fix codestyle issues * Ignore pandas' deprecation warning regarding pyarrow (#13657) * Ignore pandas' deprecation warning regarding pyarrow * Fix other deprecation warnings * Support pandas 1.x and 2.x/3.x simultaneously * Fix missing User Guide sidebars (#13659) * Update environment-release-build.yml * Use pip syntax * Force import line wrap by count and line length (#13626) * Make line_length cutoff consistent at 88 * Update the codebase * Use relative imports to shorten line lengths * add rst-files for glyphes (#13597) * Update app.rst (#13588) * Add Metadata for airports_graph.py and geojson_source.py (#13568) * Added metadata to airports_graph.py * Added metadata to geojson_source.py * Remove trailing whitespaces * Fix formating of metadata, remove some apis from airports_graph.py * Add space between tripple qoute and first letter * remove trailing white space * Add Iterable kind and use it in BooleanFilter.booleans (#13661) * update switcher.json and release notes * baseline test manual fixup --------- Co-authored-by: Demetris Roumis <[email protected]> Co-authored-by: Ian Thomas <[email protected]> Co-authored-by: Pavithra Eswaramoorthy <[email protected]> Co-authored-by: Philipp Rudiger <[email protected]> Co-authored-by: Mateusz Paprocki <[email protected]> Co-authored-by: Moritz Schreiber <[email protected]> Co-authored-by: Icoti <[email protected]> Co-authored-by: dasha-moskv <[email protected]>
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Make line_length cutoff consistent at 88 * Update the codebase * Use relative imports to shorten line lengths
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that I noticed in particular when working on PR #13625, but those long import lines have always bothered me a bit. I made the length consistent at 88, though I'm not sure where that number was taken from, as it's inconsistent with documentation and file headers (78).