Skip to content

add confirmation dialog for 3rd party fragments #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chrisrueger
Copy link
Contributor

  • show a confirmation dialog when at least one of the templates fragments to be installed is not from bndtools github organisation.
  • this is similar to the dialog shown in bndtools NewWorkspaceWizard with fragments
  • this increases security as user consent is required for installation of potentially untrusted templates

Example

You have selected 1 fragments from 3rd-party authors: 
IndexedMavenRepository - Provide an OSGi repository derived from a subset of one or more maven repositories
  - Organisation: mnlipp
  - Repo: https://github.com/mnlipp/de.mnl.osgi/tree/master/de.mnl.osgi.bnd.repository/workspace-template 

Are you sure you trust the authors and want to continue fetching the content? (yes/no): y
Added 2 template fragment(s): 
osgi - OSGi R8 with Felix distribution
  - Organisation: bndtools
  - Repo: https://github.com/bndtools/workspace-templates/tree/master/osgi 
IndexedMavenRepository - Provide an OSGi repository derived from a subset of one or more maven repositories
  - Organisation: mnlipp
  - Repo: https://github.com/mnlipp/de.mnl.osgi/tree/master/de.mnl.osgi.bnd.repository/workspace-template 

- show a confirmation dialog when at least one of the templates fragments to be installed is not from bndtools github organisation.
* this is similar to the dialog shown in bndtools NewWorkspaceWizard with fragments
* this increases security as user consent is required for installation of potentially untrusted templates

Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger chrisrueger merged commit 81d3cc6 into bndtools:master Jul 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant