Update sample app to latest tools/SDK #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes all issues reported by Android Studio, uses modern libs and classes, and complies better to Android best practices. Gradle: 7.4.2 CompileSDK: 33 Uses view binding instead of kotlin synthetics New Gradle DSL syntax Exports activity
bojackHaasman
requested changes
Sep 19, 2022
It's not related to current PR, fixed in a separate one: #14 |
bojackHaasman
requested changes
Sep 21, 2022
bojackHaasman
requested changes
Sep 21, 2022
bojackHaasman
approved these changes
Sep 22, 2022
smirko-dev
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all issues reported by Android Studio, uses modern libs and classes, and complies better to Android best practices.
Gradle: 7.4.2
CompileSDK: 33
Uses view binding instead of kotlin synthetics
New Gradle DSL syntax
Exports activity
Rename app name to not contain "Kotlin", that's obvious