Skip to content

build(macos): Allow building pre-built binaries for MacOS(darwin) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

mertssmnoglu
Copy link
Member

@mertssmnoglu mertssmnoglu commented Mar 26, 2025

We can provide pre-built binaries for MacOS, the next release may include MacOS builds.

Summary by CodeRabbit

  • Chores
    • Updated build configuration to enable macOS (Darwin) builds and clarified platform support comments.
  • Documentation
    • Removed the statement in the README indicating that Capture is only available for Linux.

@mertssmnoglu mertssmnoglu added ci-cd This issue or pull request regarding the CI/CD pipeline platform:macos MacOS Platforms labels Mar 26, 2025
@mertssmnoglu mertssmnoglu self-assigned this Mar 26, 2025
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the build configuration and documentation to reflect expanded platform support. The .goreleaser.yml file is modified to enable building for Darwin (macOS) in addition to Linux, while Windows remains disabled due to known issues. The README is updated by removing the statement that previously indicated Capture was only available for Linux, aligning the documentation with the new build capabilities.

Changes

File(s) Change Summary
.goreleaser.yml Enabled Darwin (macOS) platform build; clarified comments for Windows platform support.
README.md Removed statement restricting Capture availability to Linux only.

Poem

Hopping from Linux to Mac we go,
Expanding the places our carrots grow!
Windows waits, with a note in tow—
"Soon," says the bunny, "but not just so."
The README is lighter, the future is bright,
More platforms to capture, more code to delight!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef5b236 and a40312e.

📒 Files selected for processing (2)
  • .goreleaser.yml (1 hunks)
  • README.md (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mertssmnoglu mertssmnoglu marked this pull request as ready for review April 25, 2025 20:38
@mertssmnoglu mertssmnoglu merged commit 23c32ee into develop Apr 25, 2025
1 of 2 checks passed
@mertssmnoglu mertssmnoglu deleted the macos_builds branch April 25, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd This issue or pull request regarding the CI/CD pipeline platform:macos MacOS Platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant