Fix: #46 Inode Usage metrics #56
Conversation
WalkthroughThe changes extend disk metrics collection by enhancing the Changes
Sequence Diagram(s)sequenceDiagram
participant CM as CollectDiskMetrics
participant DU as DiskUsage
participant DD as DiskData
CM->>DU: Retrieve disk usage metrics (bytes, inodes)
DU-->>CM: Return disk usage data
CM->>DD: Set fields:\nUsedBytes, TotalInodes, FreeInodes, UsedInodes,\nInodesUsagePercent (using RoundFloatPtr)
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧬 Code Definitions (1)internal/metric/disk.go (1)
🔇 Additional comments (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/metric/disk.go (1)
82-95: Consider removing commented codeThere's a commented-out function (CollectDiskMetricsTrial) at the end of the file. While it's not related to the current changes, consider removing it in a future PR to improve code cleanliness if it's no longer needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
internal/metric/disk.go(2 hunks)internal/metric/metric.go(1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
internal/metric/disk.go (1)
internal/metric/metric_math.go (1)
RoundFloatPtr(11-14)
🔇 Additional comments (3)
internal/metric/metric.go (1)
55-61: Good addition of inode metrics to DiskDataThe new fields for tracking inode usage are a valuable enhancement to the disk metrics. This will help detect scenarios where a filesystem might run out of inodes even when there's available disk space. The fields are properly defined as pointers (consistent with existing fields), well-documented with clear comments, and have appropriate JSON tags.
internal/metric/disk.go (2)
16-22: Proper initialization of new disk data fieldsThe initialization of the new fields with nil values in the default disk data is consistent with the existing pattern. This ensures that when metrics cannot be collected, the API returns a consistent structure.
60-67: Good implementation of inode metrics collectionThe population of the new fields from the diskUsage structure is implemented correctly. The usage of RoundFloatPtr for the percentage values ensures consistent formatting with 4 decimal places. The division by 100 for the percentage fields is also consistent with how the existing UsagePercent field is handled.
There was a problem hiding this comment.
Hi @noodlewhale, thanks for your contribution. Very nice to see new 👋 faces here.
LGTM.
added inode usage metrics as part of the disk metrics.
Summary by CodeRabbit