Skip to content

fix: Add missing priceMem, priceStep in protocol param. Proper error message json for Tx submission and evaluation endpoint #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

fix: Add missing priceMem, priceStep in protocol param. Proper error message json for Tx submission and evaluation endpoint #548

merged 1 commit into from
May 5, 2025

Conversation

satran004
Copy link
Member

  1. Fix missing priceMem, priceStep in protocol param response
  2. Handle error message for Tx submission, Tx evaluation endpoint

These are required for Yaci DevKit's Lucid Evo support.

@satran004 satran004 requested a review from Sotatek-HuyLe3a May 2, 2025 16:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@satran004 satran004 mentioned this pull request May 3, 2025
Merged
@Sotatek-HuyLe3a
Copy link
Collaborator

@satran004 , LGTM

@satran004 satran004 merged commit 02feb2f into main May 5, 2025
3 of 4 checks passed
@satran004 satran004 deleted the fix/null_price_mem_protocol_param branch May 5, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sotatek-HuyLe3a Sotatek-HuyLe3a Sotatek-HuyLe3a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satran004 @Sotatek-HuyLe3a